Skip to content

Add ValidatePluginResponse #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

stefanvanburen
Copy link
Member

In the case that you have only an individual plugin response, you don't need to check for conflicting files across plugins - you just need the newly added edition validation.

We have a use-case internally where we know that we have an individual plugin response, and don't need to check for conflicting files across the only plugin.

Happy to close this if we don't like this approach, though.

In the case that you have only an individual plugin response, you don't
need to check for conflicting files across plugins - you just need the
newly added edition validation.
@stefanvanburen stefanvanburen requested review from jhump and bufdev May 3, 2024 17:13
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This validation would also catch the case where a single plugin response tried to define the same file more than once. So I think you still need it.

@stefanvanburen
Copy link
Member Author

@jhump 😖 you're right, I overlooked that. Good thought, going to close this out.

@stefanvanburen stefanvanburen deleted the svanburen/validate-individual-plugin-response branch May 3, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants