Skip to content

outline for the ACIP collection #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eroux opened this issue Apr 22, 2025 · 1 comment
Open

outline for the ACIP collection #1039

eroux opened this issue Apr 22, 2025 · 1 comment

Comments

@eroux
Copy link
Contributor

eroux commented Apr 22, 2025

(we already started but I can't find the issue if there was any so I'm opening this one)

Let's create an outline for https://library-dev.bdrc.io/show/bdr:PR1ER12 based on https://docs.google.com/spreadsheets/d/122veqABKO8v7uO_jRjp55zCTYdkftL20I2Clmu-HTr8/edit?gid=2117151629#gid=2117151629

It's already well underway, but here are some items:

  • nodes of type C (collection) should be treated as texts (TXT), not section (SEC)
  • the items that are not texts (so D not C) should appear just as they do in the document, not have their label fetched from our database, even when there's a match in column N
  • we should find a way to display the author's name (fetched from our database) in the outline by default (without the user having to click on the information button), and we can remove the information button
  • a click on a text node should open the etext viewer directly (there should be a first draft of a full import tomorrow)
  • let's remove the D... identifiers (they're made up by me for the import, they're not from the ACIP database), but let's keep the other ones
  • let's remove the [D] [T], etc. debugging indications

and after that we should be done!

berger-n added a commit that referenced this issue Apr 23, 2025
@berger-n
Copy link
Collaborator

almost all done: https://library-dev.bdrc.io/show/bdr:PR1ER12?part=bdr:MWALL_S05945M

Image

the items that are not texts (so D not C) should appear just as they do in the document, not have their label fetched from our database, even when there's a match in column N

this was already the case, the only labels that are fetched are the ones for the corresponding author/work/topic, when the "i" icon is clicked, but having a second look I'm wondering whether you were talking about using the author name from the spreadsheet as is (column L) which is currently not used no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants