Skip to content

fix(createImage): make waiting on animation frame optional #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

misino
Copy link
Contributor

@misino misino commented May 19, 2025

Added configuration property waitForAnimationFrameAcquired. Default value is false.

Closes #502

BREAKING CHANGE:
Waiting on animation frame was default behaviour since version 1.11.12. If you rely on this feature, explicitly set waitForAnimationFrameAcquired to true.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.50%. Comparing base (d9b2fcf) to head (247475c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/clone-node.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files          10       10           
  Lines         612      612           
  Branches      150      150           
=======================================
  Hits          407      407           
  Misses        144      144           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Michal Biroš added 2 commits May 19, 2025 21:53
Added configuration property waitForAnimationFrameAcquired. Default value is false.

Closes bubkoo#502

BREAKING CHANGE:

  Waiting on animation frame was default behaviour since version 1.11.12. If you rely on this feature, explicitly set waitForAnimationFrameAcquired to true.
@misino misino force-pushed the fix/make-waiting-on-frame-as-an-option branch from 095ab58 to 247475c Compare May 19, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating an image from within a service worker in an inactive browser tab is deferred
1 participant