docs(Readme): update toPixelData snippet to use width #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor docs bug that left me scratching my head for a minute, when trying to use
toPixelData
the snippet loops over the Y axis and then the X axis, however in the loop the wrong axis is used as the base, leading to mis-calculating the pixel at the XY coordinate.Every Y loop, we want to skip an entire row, so we need to multiply by the width of the image, not the height
Motivation and Context
I replicated by making a simple 6x2 r/g/b demo here, which then helped to isolate that the pixels were being read incorrectly.
Types of changes
Self Check before Merge