ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules

[shrimalmadhur]

Hello,

I am using the beta version (btcd@v0.22.0-beta) and recently I got this error while building

github.com/btcsuite/btcd/btcec tested by
github.com/btcsuite/btcd/btcec.test imports
github.com/btcsuite/btcd/chaincfg/chainhash: ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules:
github.com/btcsuite/btcd v0.22.0-beta (/Users/madhurshrimal/go/pkg/mod/github.com/btcsuite/btcd@v0.22.0-beta/chaincfg/chainhash)
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.0 (/Users/madhurshrimal/go/pkg/mod/github.com/btcsuite/btcd/chaincfg/chainhash@v1.0.0)

It didn't use to come before and suddenly it popped up. Any idea how I can solve this?

[sarvalabs-sai]

You may try deleting go.mod ,go.sum and do go clean --modcache before doing go mod init

[shrimalmadhur]

@sarvalabs-sai I did that I still get the same result.
For more context, it is happening in this repository - https://github.com/coinbase/rosetta-sdk-go during running make format command.

[chappjc]

@shrimalmadhur I believe the issue is that your make format target does go run golang.org/x/tools/cmd/goimports with no version suffix and from the module folder. From the go help run output for both go 1.17 and 1.18 (the only two Go versions that are not EOL):

If the package argument has a version suffix (like @latest or @v1.0.0),
"go run" builds the program in module-aware mode, ignoring the go.mod file in
the current directory or any parent directory, if there is one. This is useful
for running programs without affecting the dependencies of the main module.

If the package argument doesn't have a version suffix, "go run" may run in
module-aware mode or GOPATH mode, depending on the GO111MODULE environment
variable and the presence of a go.mod file. See 'go help modules' for details.
If module-aware mode is enabled, "go run" runs in the context of the main
module.

You want go run to leave your module's go.mod alone. So, you can try to append @latest:

go run golang.org/x/tools/cmd/goimports@latest -w .

Or you can just install goimports like you do with golines and goveralls. You'll have to do that if you still want to use go 1.16 or earlier. Since that feature of go run was introduced in 1.17, and there seems to be better handling with ambiguous imports with 1.17.

[erwanor]

I was having the same issue building a downstream script that uses ethclient (four or five layers removed from btcsuite/btcd/chaincfg/chainhash).

github.com/myrepo/myrepo imports
        github.com/ethereum/go-ethereum/accounts/abi/bind imports
        github.com/ethereum/go-ethereum/crypto imports
        github.com/btcsuite/btcd/btcec/v2/ecdsa tested by
        github.com/btcsuite/btcd/btcec/v2/ecdsa.test imports
        github.com/btcsuite/btcd/chaincfg/chainhash: ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules:
        github.com/btcsuite/btcd v0.20.1-beta (/home/user/go/pkg/mod/github.com/btcsuite/btcd@v0.20.1-beta/chaincfg/chainhash)
        github.com/btcsuite/btcd/chaincfg/chainhash v1.0.0 (/home/user/go/pkg/mod/github.com/btcsuite/btcd/chaincfg/chainhash@v1.0.0)

I solved it by forcing go.mod to resolve the package to the latest version (v1.0.0), by appending:

require github.com/btcd/chaincfg/chainhash v1.0.0 in my go.mod

[richardbertozzo]

The same here, what worked for me was forcing the version of btcd and go-ethereum at go.mod

module example

go 1.16

require (
	github.com/btcsuite/btcd v0.22.0-beta
	github.com/ethereum/go-ethereum v1.10.16	
)

[shrimalmadhur]

@richardbertozzo yea seems like it happens when I upgrade go-ethereum to v1.10.17 keeping the btcd version constant. I want to update to the newer version due to a security update https://github.com/coinbase/rosetta-sdk-go/security/dependabot/1

@erwanor adding that line to go.mod is still not helping my case.

[chappjc]

@shrimalmadhur Is it erroring on go build for you or just that go run command of the goimports tool? What Go version are you using?
One user of go-ethereum and btcd suggested the following, presumably for this import ambiguity issue, although I don't know what Go versions have trouble without it: ethereum/go-ethereum@f9ea1f1

[shrimalmadhur]

@chappjc I am using go1.16. So when I followed your suggestion to do the way I am doing golines - I could run the make format command but still some of the other commands (running make gen, that doesn't really install any dependency, we use it for codegen) are having the same issue.

Just saw your updated comment. let me try that.

[shrimalmadhur]

@chappjc even that other change doesn't help either

I just realized, one of our script is doing

./imports.sh;
go: downloading github.com/incu6us/goimports-reviser v0.1.6
go: downloading github.com/incu6us/goimports-reviser/v2 v2.5.1
go: downloading golang.org/x/mod v0.5.1
go: downloading golang.org/x/tools v0.1.8
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: downloading github.com/btcsuite/btcd/chaincfg/chainhash v1.0.2-0.20220316175102-8d5c75c28923
go: downloading gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c
go: downloading github.com/google/go-cmp v0.5.4
go: downloading github.com/OneOfOne/xxhash v1.2.2
go: downloading github.com/spaolacci/murmur3 v1.1.0
go: downloading github.com/leanovate/gopter v0.2.9
go: downloading github.com/kr/pretty v0.2.1
go: downloading github.com/kr/text v0.2.0
github.com/coinbase/rosetta-sdk-go/keys imports
	github.com/btcsuite/btcd/btcec tested by
	github.com/btcsuite/btcd/btcec.test imports
	github.com/btcsuite/btcd/chaincfg/chainhash: ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules:
	github.com/btcsuite/btcd v0.22.0-beta (/go/pkg/mod/github.com/btcsuite/btcd@v0.22.0-beta/chaincfg/chainhash)
	github.com/btcsuite/btcd/chaincfg/chainhash v1.0.2-0.20220316175102-8d5c75c28923 (/go/pkg/mod/github.com/btcsuite/btcd/chaincfg/chainhash@v1.0.2-0.20220316175102-8d5c75c28923)
make: *** [gen] Error 1

Specifically it's downloading - go: downloading github.com/btcsuite/btcd/chaincfg/chainhash v1.0.2-0.20220316175102-8d5c75c28923

Maybe that's the problem.

Update: The above is because I added the suggestion mentioned in go-ethereum. removing that it downloads go: downloading github.com/btcsuite/btcd/chaincfg/chainhash v1.0.0 so doesn't look like that's the issue

[chappjc]

That imports.sh issue is also related to changes in the go tooling. Namely, doing go get is trying to modify the current module, but you're really trying to install that goimports-reviser. go help get:

Building and installing packages with get is deprecated. In a future release,
the -d flag will be enabled by default, and 'go get' will be only be used to
adjust dependencies of the current module. To install a package using
dependencies from the current module, use 'go install'. To install a package
ignoring the current module, use 'go install' with an @version suffix like
"@latest" after each argument.

I just tested with Go 1.16, you can do go install github.com/incu6us/goimports-reviser/v2@latest and it will leave the go.mod alone.

[chappjc]

Also, I'm not really sure about your deps target (which codegen.sh runs) given what I noted about go get above:

deps:
	go get ./...

I think you just want go build ./... or go install ./... there.

Earlier versions of go worked very differently with go get. Now go get is aimed primarily at modifying the current module's go.{mod,sum} files, not for building or installing anything.

If at all possible, you should update to Go 1.17 or 1.18. Go 1.16 is EOL and you're not going to get any security updates, such as the one announced for release today: https://groups.google.com/g/golang-announce/c/vtbMjE04kPk/m/xE-FGxCXCAAJ?utm_medium=email&utm_source=footer

[shrimalmadhur]

@chappjc that makes sense. I think I am going to update Go first as 1.16 is EOL. for import issue I already updated the import.sh script to use go install. Let me update Go first and also change make deps. Thanks for the detail explanation. I will post an update once I've some done all those things.

[shrimalmadhur]

@chappjc Hmm. so I updated to go1.17 - It adjusted go.mod and go.sum quite a bit but I still see same issue when I put go-ethereum v1.10.17

./imports.sh;
go: downloading github.com/incu6us/goimports-reviser/v2 v2.5.1
go: downloading github.com/incu6us/goimports-reviser v0.1.6
go: downloading golang.org/x/mod v0.5.1
go: downloading golang.org/x/tools v0.1.8
go: finding module for package golang.org/x/xerrors
go: finding module for package golang.org/x/sys/execabs
go: downloading golang.org/x/sys v0.0.0-20220406163625-3f8b81556e12
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: found golang.org/x/sys/execabs in golang.org/x/sys v0.0.0-20220406163625-3f8b81556e12
go: found golang.org/x/xerrors in golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: downloading github.com/google/go-cmp v0.5.4
go: downloading github.com/spaolacci/murmur3 v1.1.0
go: downloading github.com/leanovate/gopter v0.2.9
go: downloading gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c
go: downloading github.com/OneOfOne/xxhash v1.2.2
go: downloading github.com/kr/pretty v0.2.1
go: downloading github.com/kr/text v0.2.0
go: downloading github.com/btcsuite/btcd/chaincfg/chainhash v1.0.0
github.com/coinbase/rosetta-sdk-go/keys imports
	github.com/btcsuite/btcd/btcec tested by
	github.com/btcsuite/btcd/btcec.test imports
	github.com/btcsuite/btcd/chaincfg/chainhash loaded from github.com/btcsuite/btcd@v0.22.0-beta,
	but go 1.16 would fail to locate it:
	ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules:
	github.com/btcsuite/btcd v0.22.0-beta (/go/pkg/mod/github.com/btcsuite/btcd@v0.22.0-beta/chaincfg/chainhash)
	github.com/btcsuite/btcd/chaincfg/chainhash v1.0.0 (/go/pkg/mod/github.com/btcsuite/btcd/chaincfg/chainhash@v1.0.0)

To proceed despite packages unresolved in go 1.16:
	go mod tidy -e
If reproducibility with go 1.16 is not needed:
	go mod tidy -compat=1.17
For other options, see:
	https://golang.org/doc/modules/pruning
make: *** [gen] Error 1

Not sure why it's still trying to resolve for go1.16 - but go 1.16 would fail to locate it: