Add support for PKCS12 #14
Conversation
|
Just rebased this off master since #13 merged in. Should be clean and good to go (assuming you like the approach). |
|
Actually, nevermind. I think this branch is still good, but I re-ran my tests and #13 and it seems to have broken things. Specifically, |
…o be used for authentication. Fixes bsphere#5.
… instead of converting it and removing the passphrase by hand.
|
Ok, rebased again; used it successfully to log in and acquire a token from Google. |
…ion." Realized this was out-of-scope for this change. This reverts commit 391c65f.
|
@bsphere Let me know if there’s anything I can do to make this easier to evaluate for you (or if you just don’t want this functionality built-in), since it’s been sitting for a while. |
|
I think that you should add this functionality as an option, |
|
Oh, that's exactly how it's intended to work; sorry if that wasn't clear. |
Conflicts: gapitoken.js package.json
|
I just merged the latest master into this so it’s clean again. If there are any issues, let me know. Would love to see this land if possible :) |
|
Just a friendly ping on this one. Happy to make any changes you’d like, @bsphere. |
|
Just checking in on this again, @bsphere, any changes this needs? |
|
This is now updated with tests. |
This should address #5 and allow developers to seamlessly reference the
.p12file they get from google as thekeyFileparameter or use a base64-encoded version (or a buffer) as thekeyparameter.I hope this is helpful. At the very least, I know I would have liked to have it when recently working on a project using the official Google API library, which depends on this for auth: https://github.com/google/google-api-nodejs-client
(And, of course, happy to make any tweaks you might like to the way this is done.)