horizon -> master #1787
Open
horizon -> master #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes from the un-initialized runtime
Add 'checks' CLI option for specifying which checks (all, none, or main) to execute
… desugaring later
…y not have shrunk runtime, but shrunk generated parser file size
…n't being merged as alternatives, so we could have duplicated names of generated productions
…d move the print-with-value version to `toRepr()` This is a risky change, but it seems to have a *large* improvement in parser performance: * initializing the parser drops from 0.55sec to 0.15sec, * memory usage in parsing an empty file drops from 172K to 99.7K, and time drops from 0.93sec to 0.39sec * memory usage in parsing ast.arr drops from 357K to 280K, and time drops from 3.16sec to 2.48sec `make test` passes, but please test this with caution before merging it for good
- supports cropping the function to the specified [ymin, ymax] range
…operty names where unneeded
- all charts that can be composed currently define `<prefix>xscale` and `<prefix>yscale` scales - all marks are now redefined to be placed against `xscale` and `yscale` (without the prefix) - the unprefixed `xscale` and `yscale` scales are computed as the union of the prefixed scales, and this value is indirected by way of `xscaleSignal` and `yscaleSignal` signals, so that... - the new `recompute` method is used as a callback on event listeners created with `view.addSignalListener`, which can detect when `xscaleSignal` has changed Try charting a histogram and a function plot: the function plot will initially choose an x-range of [-10, 10], and the histogram will have its own domain, and then the function will recompute itself to spread over the new merged domain.
indentation for the rest of the file
…tly, and compute the function over a domain specified by the domains of the other non-function plots in the chart
The positioning of the controls isn't right yet, but they work and they recompute the chart correctly
fix tojson number error
A new builtin module (for internal use most likely) called require-util exposes Node's require function. Note that this won't quite work in non-Node contexts without a working require. It can be polyfilled with https://github.com/browserify/resolve and ZenFS. However, ZenFS atop VScode FileSystem isn't a thing yet, so it's hard to implement it fully in the extension without some more work. Interestingly this may be a place where splitting off the behavior for the desktop extension and the web extension makes sense. The desktop extension should more easily have access to the right kind of require, and is the place where someone could plausibly run `npm install` – in the web context there's not even a way to meaningfully run npm. This would give the desktop extension (and codespaces!) the ability to use `npm`/`node_modules` infrastructure to package and distribute Pyret files. For now, this is a good CLI solution
This uses https://github.com/browserify/resolve for resolution. A few reasons: 1. It has a clean API for giving a `basedir` argument 2. It is pure JavaScript and (given a working `fs` and `path` implementation), can run in a webview/browser tab, rather than being node-internal Then, use the basedir configuration to make sure `npm` imports are resolved relative to the module containing the import (not relative to the compiler). Also update the test to have a handwritten node_modules with pyret-test-files. This ensures that when we run the _compiler_, whose working directory is the root of the repo, it must be using this new infrastructure to find the pyret-test-files module.
When resizing the chart window horizontally, the chart grows just a smidge too much, and so a horizontal scrollbar appears, and if you continue resizing horizontally back and forth, eventually the controls start to overlap the chart itself. I'm not sure why this rounding error occurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.