EXT: Add station-specific udp ports and selection of p2p connection type #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added possibility to specify udp connection type - only do cloudlookup when P2PConnectionType is set to QUICKEST
bropat
added a commit
that referenced
this pull request
Aug 23, 2024
|
I have decided to implement only the UDP port part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firewall of the CCU-devices (where my addon runs on) have either to be disabled or for each p2p connection to a station a specific port has to be provided and this port has to be excluded in the firewall settings.
So with this pull request I have implemented a possibility to specify a specific port for each station (which must be done in the background, not scope of this PR).
As second, now it is also possible to specify the p2p connection type (ONLY_LOCAL or QUICKEST). And there is a little fix, so that if ONLY_LOCAL is selected, the cloud lookup will not be performed.
@bropat: If you think, this is out-of-scope of the client, please ignore this PR.