Skip to content

NEW: add support for S220 (T8134) #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2023
Merged

Conversation

martijnpoppen
Copy link
Collaborator

No description provided.

@toshibochan
Copy link

love to see S220 working here to

@akno2205
Copy link

Please add support for S220 Cam. I have a lot of sam. Love to see it.

@ibmaster
Copy link

ibmaster commented Sep 9, 2023

Hoping this support is added soon :)

@sellighome
Copy link

Hello, thx a lot for this Eufy integration in HA. Would be nice to have also S220 (T8134) supported.

@martijnpoppen
Copy link
Collaborator Author

@bropat would you consider merging this?
I'm running this already for a while now in Homey and works perfectly :)

@mistert871
Copy link

@bropat any estimation on when this will be added / merged? I have multiple of these and really looking forward. Thanks for the good work anyway!

@mistert871
Copy link

mistert871 commented Sep 29, 2023

@bropat would you consider merging this?
I'm running this already for a while now in Homey and works perfectly :)

@martijnpoppen Hi Martijn, do you have write acces? Since it is approved someone with write acces can merge. Thanks!

@martijnpoppen
Copy link
Collaborator Author

martijnpoppen commented Sep 29, 2023

@mistert871 No I don't :/

but you can use: https://github.com/martijnpoppen/eufy-security-client/tree/homey-integration for now if you want :)

that's my custom branch for Homey to implement these kind of features before officialy merged 😄

@ccanalia82
Copy link

ccanalia82 commented Oct 4, 2023

@martijnpoppen / @bropat Are there any updates as to when this will be published? The current version doesnt seem to recognize S220, so I assume that it hasnt pushed yet. Please advise. I appreicate you.

@martijnpoppen
Copy link
Collaborator Author

@ccanalia82 i dont own this repo. It only made this pr ;)

@ccanalia82

This comment was marked as off-topic.

@bropat bropat changed the base branch from master to develop October 6, 2023 15:50
Copy link
Owner

@bropat bropat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove the zip file docs/_media/2023-08-07-08 53 23.zip
  • Missing entry for device in docs/supported_devices.md
  • Do all changeable properties work correctly?
  • Do all executable commands for device and station work (start livestream, reboot station etc.)?

@ccanalia82

This comment was marked as off-topic.

@ccanalia82

This comment was marked as off-topic.

@martijnpoppen
Copy link
Collaborator Author

@bropat updated as requested.

@bropat
Copy link
Owner

bropat commented Oct 6, 2023

@martijnpoppen

If you own the device, I still need an answer to the following questions:

  • Do all changeable properties work correctly?
  • Do all executable commands for device and station work (start livestream, reboot station etc.)?

@martijnpoppen
Copy link
Collaborator Author

@bropat I don't own it and can't test either

@bropat
Copy link
Owner

bropat commented Oct 11, 2023

@ibmaster or @ccanalia82
Will get back to you in the next few days to run some the tests.

@ccanalia82
Copy link

@ibmaster / @bropat
I decided to return this camera as the S40 was on sale for the same price for Prime Day. I wont be able to help test this device.

@mistert871
Copy link

@ibmaster / @bropat
I decided to return this camera as the S40 was on sale for the same price for Prime Day. I wont be able to help test this device.

@ibmaster @bropat
I have a spare S220 that I can configure for you. If you have a demo Eufy account I can register the device on that or shall I make temp account?

@bropat
Copy link
Owner

bropat commented Oct 17, 2023

@ibmaster
You can share the device with admin rights to:

@mistert871
Copy link

mistert871 commented Oct 17, 2023

@ibmaster You can share the device with admin rights to:

@ibmaster @bropat - Done! You can check now. Can you please let me know when I can delete acces? Camera has no (good) vision as I blocked it. I also disabled the MIC so that you know. Please let me know if you need anything else.

@bropat
Copy link
Owner

bropat commented Oct 17, 2023

Done! You can check now. Can you please let me know when I can delete acces? Camera has no (good) vision as I blocked it. I also disabled the MIC so that you know. Please let me know if you need anything else.

@ibmaster
Thank you!
I'll let you know as soon as I no longer need access.
I will also let you know that I need to use and test all the features to implement the device.
e.g. start/stop livestream etc.

@tango13
Copy link

tango13 commented Oct 18, 2023

I also have an S220 and I am willing to contribute with testing, even though I am no expert in HA. Thank you.

Fixed setWatermark command for T8134
…eviceVideoRecordingQuality, DeviceChargingStatus properties for device T8134
@bropat
Copy link
Owner

bropat commented Oct 18, 2023

Short update:

I have already fixed some functionalities and tested them successfully (incl. live streaming).

Todo:

  • Fix detection mode type property (human vs all motions)
  • Complete testing

@tango13
Copy link

tango13 commented Oct 19, 2023

Noob here :)
Could anyone please briefly explain how I could use the pulled code for testing?
I have eufy-security-ws addon and eufy security integration installed in my HA but I can't figure out how to integrate the new code.
Thank you.

@tango13
Copy link

tango13 commented Oct 21, 2023

I managed to get it up and running, starting to test it.
For now I can see a lot of entities, so far so good!
Thanks a lot

@tango13
Copy link

tango13 commented Oct 23, 2023

I'm playing a bit with a S220 cam and it seems to work pretty well.
The only thing that I've noticed so far is when I press the "Start P2P stream" button: after that I get a "PREPARING" stream status and then sometimes I get the stream and sometimes not, with the status remaining in the preparing state.
Is there anything particular I should try to test?
Thanks.

@mistert871
Copy link

Any update @bropat ? Just curious and hoping the support will be ready soon. Let me know if you don't need any access anymore. Thanks!

@bropat bropat merged commit 383faaa into bropat:develop Nov 4, 2023
@bropat
Copy link
Owner

bropat commented Nov 4, 2023

@mistert871

No, thank you!

@d4nm0

This comment has been minimized.

Repository owner locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.