Bug - Hooks: 'OnMount' effect is not disposed when hierarchy is removed #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking 🕵 |
|
Is this correctly closed? |
|
I don't think so @tcoopman |
|
The test does verify if the unmount effect is called once so I believe it covers #41. |
wokalski
changed the title
wokalski
approved these changes
Sep 27, 2019
This was referenced Oct 4, 2019
18 tasks
wokalski
added a commit
that referenced
this pull request
Oct 27, 2019
('OnMount' effect is not disposed when hierarchy is removed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
This adds a test case reproducing the issue - when a parent-of-a-parent is removed, the child OnMount effects are not disposed properly.
This impacted Revery's animations (if you remove an animating element, it uses the OnMount hook disposal to un-register the animation) - it would keep animations alive when transitioning between elements.
Related to #8