Skip to content
This repository was archived by the owner on Apr 22, 2021. It is now read-only.

Fix https://github.com/brave/brave-browser/issues/4419 #13

Closed
wants to merge 2 commits into from

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Sep 27, 2019

Made generic to cover companies using custom domains.

Should fix the issue reported in brave/brave-browser#4419

@fmarier
Copy link
Member

fmarier commented Sep 27, 2019

It seems a little excessive to whitelist that domain on all pages. I'm trying to find a tighter rule.

@ryanbr
Copy link
Collaborator Author

ryanbr commented Sep 27, 2019

It seems a little excessive to whitelist that domain on all pages. I'm trying to find a tighter rule.

           ` "https://*.atlassian.net/secure/*"`

Maybe?

#edit. Maybe not,

@fmarier
Copy link
Member

fmarier commented Sep 27, 2019

I'm hoping we don't have to whitelist it globally, so something like (doesn't work yet):

        {
            "https://*.atlassian.com/*": [
                "https://*.atlassian.net/*"
            ]
        },
        {
            "https://*.jira.com/*": [
                "https://*.atlassian.net/*"
            ]
        }

@fmarier
Copy link
Member

fmarier commented Sep 27, 2019

That said, I can confirm that the global whitelisting works, so it's definitely a missing referrer on atlassian.net that's causing this pain

@ryanbr
Copy link
Collaborator Author

ryanbr commented Sep 27, 2019

The main issue possibly would be companies uising atlassian services, but with there own domains. why chose the global whitelist, ofcourse if there is a better solution

@fmarier
Copy link
Member

fmarier commented Sep 28, 2019

I don't have write access to this repo yet so I can't edit issues/PRs, so I've had to put the tighter fix I found in a separate PR: #14

@ryanbr ryanbr closed this Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants