Skip to content

Add animation to button menu and nala styles #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 11, 2025
Merged

Add animation to button menu and nala styles #1110

merged 8 commits into from
Jun 11, 2025
+60 −32

Conversation

aguscruiz
Copy link
Collaborator

@aguscruiz aguscruiz commented Jun 3, 2025 •
edited
Loading

Resolves #1106

Added an animation with the help of cursor. Need a review.

Getting these warnings on the terminal too but attempted to fix with cursor.
image

@aguscruiz
Add animation to button menu and nala styles
3cafa31 
Added an animation with the help of cursor. Need a review
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1110.pr.nala.bravesoftware.com/
✅ Commit preview: https://1110.pr.nala.bravesoftware.com/commit-3cafa31e9a84d029b795733e27ae22174250f3eb/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff 
--- ./tokens/css/variables-android.old.css	2025-06-03 12:18:45.086351895 +0000
+++ ./tokens/css/variables-android.css	2025-06-03 12:18:10.402623190 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff 
--- ./tokens/css/variables-browser.old.css	2025-06-03 12:18:45.251351736 +0000
+++ ./tokens/css/variables-browser.css	2025-06-03 12:18:10.390622738 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff 
--- ./tokens/css/variables-ios.old.css	2025-06-03 12:18:45.464351532 +0000
+++ ./tokens/css/variables-ios.css	2025-06-03 12:18:10.417623755 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff 
--- ./tokens/css/variables-marketing.old.css	2025-06-03 12:18:45.627351373 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-03 12:18:10.436624471 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff 
--- ./tokens/css/variables-news.old.css	2025-06-03 12:18:45.785351221 +0000
+++ ./tokens/css/variables-news.css	2025-06-03 12:18:10.467625638 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff 
--- ./tokens/css/variables-newtab.old.css	2025-06-03 12:18:45.939351070 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-03 12:18:10.474625902 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff 
--- ./tokens/css/variables-search.old.css	2025-06-03 12:18:46.128350889 +0000
+++ ./tokens/css/variables-search.css	2025-06-03 12:18:10.462625450 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff 
--- ./tokens/css/variables-web3.old.css	2025-06-03 12:18:46.325350698 +0000
+++ ./tokens/css/variables-web3.css	2025-06-03 12:18:10.478626053 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff 
--- ./tokens/css/variables.old.css	2025-06-03 12:18:46.580350451 +0000
+++ ./tokens/css/variables.css	2025-06-03 12:18:10.259617804 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:18:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1110.pr.nala.bravesoftware.com/
✅ Commit preview: https://1110.pr.nala.bravesoftware.com/commit-22fb2157a3d11dc508ff2b3470a0aa915190673f/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff 
--- ./tokens/css/variables-android.old.css	2025-06-03 12:34:39.946012692 +0000
+++ ./tokens/css/variables-android.css	2025-06-03 12:34:04.540506316 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff 
--- ./tokens/css/variables-browser.old.css	2025-06-03 12:34:40.225008753 +0000
+++ ./tokens/css/variables-browser.css	2025-06-03 12:34:04.522506570 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff 
--- ./tokens/css/variables-ios.old.css	2025-06-03 12:34:40.556004081 +0000
+++ ./tokens/css/variables-ios.css	2025-06-03 12:34:04.554506119 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff 
--- ./tokens/css/variables-marketing.old.css	2025-06-03 12:34:40.845999987 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-03 12:34:04.577505795 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff 
--- ./tokens/css/variables-news.old.css	2025-06-03 12:34:41.123996062 +0000
+++ ./tokens/css/variables-news.css	2025-06-03 12:34:04.601505457 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff 
--- ./tokens/css/variables-newtab.old.css	2025-06-03 12:34:41.400992155 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-03 12:34:04.608505358 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff 
--- ./tokens/css/variables-search.old.css	2025-06-03 12:34:41.674988286 +0000
+++ ./tokens/css/variables-search.css	2025-06-03 12:34:04.596505527 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff 
--- ./tokens/css/variables-web3.old.css	2025-06-03 12:34:41.942984500 +0000
+++ ./tokens/css/variables-web3.css	2025-06-03 12:34:04.613505288 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff 
--- ./tokens/css/variables.old.css	2025-06-03 12:34:42.242980265 +0000
+++ ./tokens/css/variables.css	2025-06-03 12:34:04.367508756 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Jun 03 2025 10:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Jun 03 2025 12:34:04 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

fallaciousreasoning
fallaciousreasoning reviewed Jun 4, 2025
View reviewed changes
src/components/buttonMenu/buttonMenu.svelte Outdated
Comment on lines 62 to 69
in:fade={{ duration: 150 }}
out:fade={{ duration: 100 }}
>
<div
class="menu-content"
in:scale={{ duration: 150, start: 0.95 }}
out:scale={{ duration: 100, start: 1 }}
>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this will work, the problem is that Svelte's animation system breaks our tests in brave-core 😢

Any chance you could try making the animation work with CSS animations?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fallaciousreasoning migrated it to css. What do you think now?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1110.pr.nala.bravesoftware.com/
✅ Commit preview: https://1110.pr.nala.bravesoftware.com/commit-b53e604966b6a28a99c72cb8b93ee8869713ba74/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff 
--- ./tokens/css/variables-android.old.css	2025-06-05 13:39:46.108991876 +0000
+++ ./tokens/css/variables-android.css	2025-06-05 13:39:11.959091526 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff 
--- ./tokens/css/variables-browser.old.css	2025-06-05 13:39:46.378992463 +0000
+++ ./tokens/css/variables-browser.css	2025-06-05 13:39:11.947090960 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff 
--- ./tokens/css/variables-ios.old.css	2025-06-05 13:39:46.632993015 +0000
+++ ./tokens/css/variables-ios.css	2025-06-05 13:39:11.973092185 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff 
--- ./tokens/css/variables-marketing.old.css	2025-06-05 13:39:46.867993525 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-05 13:39:11.992093081 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff 
--- ./tokens/css/variables-news.old.css	2025-06-05 13:39:47.113994060 +0000
+++ ./tokens/css/variables-news.css	2025-06-05 13:39:12.022094494 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:12 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff 
--- ./tokens/css/variables-newtab.old.css	2025-06-05 13:39:47.361994596 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-05 13:39:12.029094824 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:12 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff 
--- ./tokens/css/variables-search.old.css	2025-06-05 13:39:47.635995193 +0000
+++ ./tokens/css/variables-search.css	2025-06-05 13:39:12.017094258 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:12 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff 
--- ./tokens/css/variables-web3.old.css	2025-06-05 13:39:47.869995701 +0000
+++ ./tokens/css/variables-web3.css	2025-06-05 13:39:12.033095012 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:12 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff 
--- ./tokens/css/variables.old.css	2025-06-05 13:39:48.154996321 +0000
+++ ./tokens/css/variables.css	2025-06-05 13:39:11.822085071 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 05 2025 13:39:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

petemill
petemill reviewed Jun 5, 2025
View reviewed changes
src/components/buttonMenu/buttonMenu.stories.svelte Outdated
Comment on lines 30 to 44

function handleKeydown(event: KeyboardEvent) {
if (event.key === 'Enter' || event.key === ' ') {
event.preventDefault()
handleAction()
}
}

function handleToggleKeydown(event: KeyboardEvent) {
if (event.key === 'Enter' || event.key === ' ') {
event.preventDefault()
handleAction()
toggleIsChecked = !toggleIsChecked
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping

petemill
petemill reviewed Jun 5, 2025
View reviewed changes
src/components/buttonMenu/buttonMenu.stories.svelte Outdated
Comment on lines 51 to 69
<leo-menu-item
role="menuitem"
on:click={handleAction}
on:keydown={handleKeydown}
tabindex="0"
>
Copy
</leo-menu-item>
<leo-menu-item
role="menuitem"
tabindex="0"
>
Share
</leo-menu-item>
<div class="section">Section</div>
<leo-menu-item>
<leo-menu-item
role="menuitem"
tabindex="0"
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

petemill
petemill reviewed Jun 5, 2025
View reviewed changes
src/components/buttonMenu/buttonMenu.svelte Outdated
Comment on lines 59 to 60
<div class="menu-wrapper">
<div class="menu-content">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should try with a single element

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we should try it in the menu component

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1110.pr.nala.bravesoftware.com/
✅ Commit preview: https://1110.pr.nala.bravesoftware.com/commit-fbf0921f1f1c4ea4831457ab0823b8def79e285d/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff 
--- ./tokens/css/variables-android.old.css	2025-06-06 13:49:14.611135903 +0000
+++ ./tokens/css/variables-android.css	2025-06-06 13:48:39.979855906 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff 
--- ./tokens/css/variables-browser.old.css	2025-06-06 13:49:14.829137690 +0000
+++ ./tokens/css/variables-browser.css	2025-06-06 13:48:39.967855805 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff 
--- ./tokens/css/variables-ios.old.css	2025-06-06 13:49:15.049139493 +0000
+++ ./tokens/css/variables-ios.css	2025-06-06 13:48:39.994856032 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff 
--- ./tokens/css/variables-marketing.old.css	2025-06-06 13:49:15.153140346 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-06 13:48:40.014856200 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff 
--- ./tokens/css/variables-news.old.css	2025-06-06 13:49:15.337141856 +0000
+++ ./tokens/css/variables-news.css	2025-06-06 13:48:40.035856376 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff 
--- ./tokens/css/variables-newtab.old.css	2025-06-06 13:49:15.527143411 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-06 13:48:40.042856435 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff 
--- ./tokens/css/variables-search.old.css	2025-06-06 13:49:15.722145012 +0000
+++ ./tokens/css/variables-search.css	2025-06-06 13:48:40.031856343 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff 
--- ./tokens/css/variables-web3.old.css	2025-06-06 13:49:15.966146978 +0000
+++ ./tokens/css/variables-web3.css	2025-06-06 13:48:40.046856469 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:40 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff 
--- ./tokens/css/variables.old.css	2025-06-06 13:49:16.282149528 +0000
+++ ./tokens/css/variables.css	2025-06-06 13:48:39.838854723 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:48:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1110.pr.nala.bravesoftware.com/
✅ Commit preview: https://1110.pr.nala.bravesoftware.com/commit-db38acbc7bd6ec2f6a07c6ac53b8cbb30159bb4e/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff 
--- ./tokens/css/variables-android.old.css	2025-06-06 13:51:26.695624390 +0000
+++ ./tokens/css/variables-android.css	2025-06-06 13:50:52.541810523 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff 
--- ./tokens/css/variables-browser.old.css	2025-06-06 13:51:26.870623416 +0000
+++ ./tokens/css/variables-browser.css	2025-06-06 13:50:52.526810608 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff 
--- ./tokens/css/variables-ios.old.css	2025-06-06 13:51:27.064622340 +0000
+++ ./tokens/css/variables-ios.css	2025-06-06 13:50:52.554810450 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff 
--- ./tokens/css/variables-marketing.old.css	2025-06-06 13:51:27.250621273 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-06 13:50:52.571810354 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff 
--- ./tokens/css/variables-news.old.css	2025-06-06 13:51:27.428619481 +0000
+++ ./tokens/css/variables-news.css	2025-06-06 13:50:52.593810230 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff 
--- ./tokens/css/variables-newtab.old.css	2025-06-06 13:51:27.652617218 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-06 13:50:52.600810190 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff 
--- ./tokens/css/variables-search.old.css	2025-06-06 13:51:27.844615277 +0000
+++ ./tokens/css/variables-search.css	2025-06-06 13:50:52.588810258 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff 
--- ./tokens/css/variables-web3.old.css	2025-06-06 13:51:28.034613361 +0000
+++ ./tokens/css/variables-web3.css	2025-06-06 13:50:52.604810168 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff 
--- ./tokens/css/variables.old.css	2025-06-06 13:51:28.334610329 +0000
+++ ./tokens/css/variables.css	2025-06-06 13:50:52.386811397 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 05 2025 06:33:48 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 06 2025 13:50:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

AlanBreck
AlanBreck approved these changes Jun 7, 2025
View reviewed changes
Copy link
Collaborator

@AlanBreck AlanBreck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but the animation looks good!

src/components/buttonMenu/buttonMenu.stories.svelte
Comment on lines +180 to +182
padding: var(--leo-menu-item-padding);
font: var(--leo-font-small-regular);
color: var(--leo-color-text-secondary);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why these changes?

fallaciousreasoning
fallaciousreasoning approved these changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that there's a comment from @petemill in the storybook about removing some code 😄

This looks good - just wanted to confirm its intentional we have no exit animation?

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1110.pr.nala.bravesoftware.com/
✅ Commit preview: https://1110.pr.nala.bravesoftware.com/commit-2008271be19b4bd235d8f866b0a8cc5208026882/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff 
--- ./tokens/css/variables-android.old.css	2025-06-11 21:07:41.941635764 +0000
+++ ./tokens/css/variables-android.css	2025-06-11 21:07:06.788986470 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff 
--- ./tokens/css/variables-browser.old.css	2025-06-11 21:07:42.158634501 +0000
+++ ./tokens/css/variables-browser.css	2025-06-11 21:07:06.775986231 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff 
--- ./tokens/css/variables-ios.old.css	2025-06-11 21:07:42.504632490 +0000
+++ ./tokens/css/variables-ios.css	2025-06-11 21:07:06.811986895 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff 
--- ./tokens/css/variables-marketing.old.css	2025-06-11 21:07:42.741631109 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-11 21:07:06.827987190 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff 
--- ./tokens/css/variables-news.old.css	2025-06-11 21:07:43.026629453 +0000
+++ ./tokens/css/variables-news.css	2025-06-11 21:07:06.848987577 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff 
--- ./tokens/css/variables-newtab.old.css	2025-06-11 21:07:43.283627956 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-11 21:07:06.856987725 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff 
--- ./tokens/css/variables-search.old.css	2025-06-11 21:07:43.531626511 +0000
+++ ./tokens/css/variables-search.css	2025-06-11 21:07:06.844987504 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff 
--- ./tokens/css/variables-web3.old.css	2025-06-11 21:07:43.779625069 +0000
+++ ./tokens/css/variables-web3.css	2025-06-11 21:07:06.859987780 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff 
--- ./tokens/css/variables.old.css	2025-06-11 21:07:44.142622956 +0000
+++ ./tokens/css/variables.css	2025-06-11 21:07:06.637983685 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:07:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1110.pr.nala.bravesoftware.com/
✅ Commit preview: https://1110.pr.nala.bravesoftware.com/commit-755f81e468b89a7c5f797523227e1d24a3502207/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff 
--- ./tokens/css/variables-android.old.css	2025-06-11 21:11:39.674368999 +0000
+++ ./tokens/css/variables-android.css	2025-06-11 21:11:03.392576689 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff 
--- ./tokens/css/variables-browser.old.css	2025-06-11 21:11:39.821368598 +0000
+++ ./tokens/css/variables-browser.css	2025-06-11 21:11:03.380578592 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff 
--- ./tokens/css/variables-ios.old.css	2025-06-11 21:11:39.996368112 +0000
+++ ./tokens/css/variables-ios.css	2025-06-11 21:11:03.406574470 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff 
--- ./tokens/css/variables-marketing.old.css	2025-06-11 21:11:40.158367660 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-11 21:11:03.423571775 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff 
--- ./tokens/css/variables-news.old.css	2025-06-11 21:11:40.362367102 +0000
+++ ./tokens/css/variables-news.css	2025-06-11 21:11:03.444568446 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff 
--- ./tokens/css/variables-newtab.old.css	2025-06-11 21:11:40.539366613 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-11 21:11:03.451567336 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff 
--- ./tokens/css/variables-search.old.css	2025-06-11 21:11:40.696366181 +0000
+++ ./tokens/css/variables-search.css	2025-06-11 21:11:03.439569238 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff 
--- ./tokens/css/variables-web3.old.css	2025-06-11 21:11:40.788365927 +0000
+++ ./tokens/css/variables-web3.css	2025-06-11 21:11:03.455566702 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff 
--- ./tokens/css/variables.old.css	2025-06-11 21:11:41.007365323 +0000
+++ ./tokens/css/variables.css	2025-06-11 21:11:03.253598725 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 21:11:03 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1110.pr.nala.bravesoftware.com/
✅ Commit preview: https://1110.pr.nala.bravesoftware.com/commit-a7a0e9326d27fd88d4a9d4786549892018b75113/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff 
--- ./tokens/css/variables-android.old.css	2025-06-11 22:21:25.975167567 +0000
+++ ./tokens/css/variables-android.css	2025-06-11 22:20:49.635358016 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff 
--- ./tokens/css/variables-browser.old.css	2025-06-11 22:21:26.194167297 +0000
+++ ./tokens/css/variables-browser.css	2025-06-11 22:20:49.622357769 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff 
--- ./tokens/css/variables-ios.old.css	2025-06-11 22:21:26.433167007 +0000
+++ ./tokens/css/variables-ios.css	2025-06-11 22:20:49.656358415 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff 
--- ./tokens/css/variables-marketing.old.css	2025-06-11 22:21:26.677166707 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-11 22:20:49.677358815 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff 
--- ./tokens/css/variables-news.old.css	2025-06-11 22:21:26.900166434 +0000
+++ ./tokens/css/variables-news.css	2025-06-11 22:20:49.699359234 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff 
--- ./tokens/css/variables-newtab.old.css	2025-06-11 22:21:27.143166138 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-11 22:20:49.706359367 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff 
--- ./tokens/css/variables-search.old.css	2025-06-11 22:21:27.377165852 +0000
+++ ./tokens/css/variables-search.css	2025-06-11 22:20:49.694359139 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff 
--- ./tokens/css/variables-web3.old.css	2025-06-11 22:21:27.609165567 +0000
+++ ./tokens/css/variables-web3.css	2025-06-11 22:20:49.710359443 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:33 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff 
--- ./tokens/css/variables.old.css	2025-06-11 22:21:27.991165100 +0000
+++ ./tokens/css/variables.css	2025-06-11 22:20:49.484355143 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Jun 11 2025 18:35:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Jun 11 2025 22:20:49 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@aguscruiz aguscruiz merged commit 18dbd69 into main Jun 11, 2025
6 checks passed
@aguscruiz aguscruiz deleted the button-menu-animation branch June 11, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petemill petemill petemill left review comments

@AlanBreck AlanBreck AlanBreck approved these changes

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add animation to button-menu component on click
4 participants
@aguscruiz @petemill @AlanBreck @fallaciousreasoning