This repository was archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13756 +/- ##
=======================================
Coverage 56.78% 56.78%
=======================================
Files 285 285
Lines 29038 29038
Branches 4803 4803
=======================================
Hits 16488 16488
Misses 12550 12550
|
Resolves brave#13754 Auditors: Test Plan:
25f5e17
to
6d8de0c
Compare
bsclifton
approved these changes
Apr 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regex changes look good; unit tests cover the previous and added functionality. Nice job with the postinstall-test.sh
script 😄
@bsclifton that script is all @petemill 😃 |
bsclifton
added a commit
that referenced
this pull request
Apr 6, 2018
Adds s-s to the referral code
bsclifton
added a commit
that referenced
this pull request
Apr 6, 2018
Adds s-s to the referral code
bsclifton
added a commit
that referenced
this pull request
Apr 6, 2018
Adds s-s to the referral code
bsclifton
added a commit
that referenced
this pull request
Apr 12, 2018
This reverts commit 06c774b.
NejcZdovc
pushed a commit
that referenced
this pull request
Apr 18, 2018
Adds s-s to the referral code
0.22.x-c66 1625a7c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13754
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Instead of just supporting
pem001
(3 letters and 3 numbers) we need to supportorg-name
(at least 1 letter, dash and at least 1 letter) as well.Copied test script from #13113
Mac OS
Windows:
Reviewer Checklist:
Tests