Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Fixes locale mix #351

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Fixes locale mix #351

merged 1 commit into from
Jan 21, 2019

Conversation

NejcZdovc
Copy link
Contributor

Changes

  • changes locale to be unique so that doesn't mess up notification title

Test plan

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@NejcZdovc NejcZdovc self-assigned this Jan 21, 2019
@NejcZdovc NejcZdovc requested a review from ryanml January 21, 2019 11:44
@NejcZdovc NejcZdovc merged commit d0369cb into master Jan 21, 2019
@NejcZdovc NejcZdovc deleted the token-grant branch January 21, 2019 12:34
NejcZdovc added a commit that referenced this pull request Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants