Skip to content

Fix #17569, #17570 - Fix disconnect state for Gemini when wallet linking fails #9817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Aug 22, 2021

Resolves brave/brave-browser#17569
Resolves brave/brave-browser#17570

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable Gemini flags
  2. Enable Brave Rewards
  3. Verify with Gemini using account A
  4. Disconnect rewards
  5. Verify the status shows Verify Wallet
  6. Verify with Gemini using account B
  7. On verification an error should be displayed
  8. Wallet status should show Verify Wallet

Screen Shot 2021-08-22 at 8 17 13 PM

@jumde jumde requested a review from a team as a code owner August 22, 2021 23:58
@jumde jumde requested review from deeppandya and zenparsing August 22, 2021 23:58
@jumde jumde changed the title Fix #17569, ##17570 - Fix disconnect state for Gemini when wallet linking fails Fix #17569, #17570 - Fix disconnect state for Gemini when wallet linking fails Aug 23, 2021
@jumde jumde force-pushed the disconnect_state branch from 680dd48 to ee25033 Compare August 23, 2021 01:06
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jumde jumde merged commit 3ced778 into master Aug 23, 2021
@jumde jumde deleted the disconnect_state branch August 23, 2021 15:57
@jumde jumde added this to the 1.30.x - Nightly milestone Aug 23, 2021
brave-builds pushed a commit that referenced this pull request Aug 23, 2021
@LaurenWags
Copy link
Member

Verified using:

Brave	1.30.43 Chromium: 93.0.4577.51 (Official Build) nightly (x86_64)
Revision	762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS	macOS Version 11.5.2 (Build 20G95)

Verified test plan from #9817 (comment)
Verified STR from brave/brave-browser#17569
Verified STR from brave/brave-browser#17570

Confirmed an error message is shown. Note, error text is generic and not descriptive of the problem. Logged brave/brave-browser#17661. This does not reproduce for Uphold but does reproduce for bitFlyer (brave/brave-browser#17592):

Screen Shot 2021-08-24 at 8 39 01 AM

Confirmed UI returns to pre-link state. It does not show "Disconnected" UI or a balance. "Verify wallet" is shown and no balance is displayed:

Screen Shot 2021-08-24 at 8 39 26 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants