Skip to content

Move iOS recovery code into Backup and Restore modal #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jul 27, 2021

Resolves brave/brave-browser#16954

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Launch Brave
  • Visit brave://rewards
  • Verify that QR code section doesn't appear in Settings page
  • Click gear icon
  • Select the Restore tab in the modal
  • Verify that QR code link looks as expected
  • Click the QR code link
  • Verify that appropriate QR code displays
  • Verify that QR code functions as expected

@emerick emerick requested a review from a team July 27, 2021 17:35
@emerick emerick self-assigned this Jul 27, 2021
@emerick emerick requested review from jumde and zenparsing and removed request for a team July 27, 2021 17:35
@emerick emerick force-pushed the rewards-move-ios-qr-code branch from adaaaec to 61e5e78 Compare July 27, 2021 18:30
@emerick emerick requested a review from a team as a code owner July 27, 2021 18:30
@emerick emerick force-pushed the rewards-move-ios-qr-code branch 2 times, most recently from f976308 to 8b41da9 Compare July 28, 2021 18:16
@emerick emerick force-pushed the rewards-move-ios-qr-code branch from 8b41da9 to 8eadbfa Compare July 28, 2021 19:54
@emerick emerick requested a review from zenparsing July 28, 2021 19:55
Copy link
Collaborator

@szilardszaloki szilardszaloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move iOS recovery code option to Backup & Restore (Manage Your Wallet) area
3 participants