Skip to content

Fix inconsistent capitalization in main menu #8961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Fix inconsistent capitalization in main menu #8961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/brave_generated_resources.grd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
Brave Ad Block
</message>
<message name="IDS_SHOW_BRAVE_WEBCOMPAT_REPORTER" desc="The menu item to report a broken site in the app menu">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ui strings need to stay title case for macos and can change for windows and linux.

Wrap the message inside <if expr="use_titlecase">...</if> so macos strings will be parsed within the if and wrap non title case <if expr="not use_titlecase">...</if> - Follow this for all the strings that needs to be changed.

Here's an example: https://source.chromium.org/chromium/chromium/src/+/main:ui/strings/ui_strings.grd;l=623-632?q=grd%20%22%3Cif%20expr%3D%22use_titlecase%22%3E%22

Copy link
Member

@bsclifton bsclifton Jul 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wyatt400 even though I had already merged the code, you could do this as a follow up (in a new branch, new pull request) and we'll help you sort it out 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsclifton So is this being reverted?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No revert needed! You can create a new patch with the feedback above though 😄

Report a Broken Site
Report a broken site
</message>
<message name="IDS_SHOW_BRAVE_SYNC" desc="The show brave sync menu in the app menu">
Sync
Expand All @@ -176,10 +176,10 @@
Wallet
</message>
<message name="IDS_ADD_NEW_PROFILE" desc="The app menu item to create a new User Profile">
Create a New Profile
Create a new profile
</message>
<message name="IDS_OPEN_GUEST_PROFILE" desc="The app menu item to create a new User Profile">
Open Guest Window
Open guest window
</message>
<message name="IDS_OPEN_MORE_OTHER_DEVICES_SESSIONS" desc="The history sub-menu item to show sessions from other devices">
More…
Expand Down