Skip to content

Remove sync v1 leftovers #8879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2021
Merged

Remove sync v1 leftovers #8879

merged 1 commit into from
May 21, 2021

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented May 20, 2021

Resolves brave/brave-browser#15791

This PR removes some sync v1 extension leftovers.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A

@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review May 20, 2021 11:26
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexeyBarabash
Copy link
Contributor Author

macOSX build is marked is UNSTABLE,

Failed
macos-x64 / test-browser / AdBlockServiceTest.CnameCloakedRequestsGetBlocked
  • not related to the PR

@AlexeyBarabash
Copy link
Contributor Author

AlexeyBarabash commented May 20, 2021

Pre-init CI step is UNSTABLE
https://ci.brave.com/job/pr-brave-browser-sync_v1_leftovers-pre-init/2/execution/node/139/

Node Record compiler warnings and static analysis results
Parents
Shell Script
{unstableTotalAll=1, sourceCodeEncoding=UTF-8, tools=[@pyLint(pattern=pylint-report.txt,reportEncoding=UTF-8)], failOnError=true}

at the same time npm run pylint -- --compare-with master gives the same errors both on master and on sync_v1_leftovers :

 [email protected] pylint /mnt/EVO970/Projects/br_br_master/brave-browser/src/brave
 ./script/pylint.sh "--compare-with" "master"

Checking for pylint findings in scripts changed relative to master in: build/ components/ installer/ script/ tools/
Module audit_deps
C: 68, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C: 75, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C: 91, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:101, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:105, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:110, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:111, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:114, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
W:105,52: Used builtin function 'map'. Using a list comprehension can be clearer. (bad-builtin)

so not related to the PR

@AlexeyBarabash AlexeyBarabash merged commit dfe4da5 into master May 21, 2021
@AlexeyBarabash AlexeyBarabash deleted the sync_v1_leftovers branch May 21, 2021 05:46
@AlexeyBarabash AlexeyBarabash added this to the 1.27.x - Nightly milestone May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync v1 leftovers
4 participants