Skip to content

[Android] Fixes unresponsive close button from Site Settings options #8372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2021
Merged

[Android] Fixes unresponsive close button from Site Settings options #8372

merged 4 commits into from
Mar 29, 2021

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented Mar 26, 2021 •
edited by deeppandya
Loading

Resolves brave/brave-browser#12181

Submitter Checklist:

  • [ x] I confirm that no security/privacy review is needed, or that I have requested one
  • [ x] There is a ticket for my issue
  • [ x] Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 26, 2021
@alexsafe alexsafe added this to the 1.24.x - Nightly milestone Mar 26, 2021
@alexsafe alexsafe requested a review from samartnik as a code owner March 26, 2021 22:20
@alexsafe alexsafe self-assigned this Mar 26, 2021
samartnik
samartnik approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexsafe alexsafe merged commit 6d6734c into master Mar 29, 2021
@alexsafe alexsafe deleted the close_site_settings_subpages branch March 29, 2021 21:29
@alexsafe alexsafe mentioned this pull request Mar 29, 2021
Closed
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
@Uni-verse
Add Release Notes for iOS Release 1.52.1 (#8372)
d6a0579 
* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samartnik samartnik samartnik approved these changes

@deeppandya deeppandya Awaiting requested review from deeppandya

@SergeyZhukovsky SergeyZhukovsky Awaiting requested review from SergeyZhukovsky

Assignees

@alexsafe alexsafe

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging this pull request may close these issues.

[Android] Tapping 'X' on Site settings pages doesn't do anything
2 participants
@alexsafe @samartnik