Skip to content

Fix compile error due to rewards resources #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 25, 2018

Fix build error from yarn create_dist Release.
This is a follow up for #719 to fix a windows build issue

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong simonhong requested a review from bridiver October 25, 2018 07:16
@simonhong simonhong self-assigned this Oct 25, 2018
@simonhong
Copy link
Member Author

Another unit test build error is fixed by brave-intl/bat-native-ledger#157

@bbondy bbondy merged commit 1facc37 into master Oct 25, 2018
bbondy added a commit that referenced this pull request Oct 25, 2018
Fix compile error due to rewards resources
bbondy added a commit that referenced this pull request Oct 25, 2018
Fix compile error due to rewards resources
@bbondy
Copy link
Member

bbondy commented Oct 25, 2018

master: 1facc37
0.57.x: 9d89ab0
0.56.x: f7f0870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants