Moves promotions to new endpoint structure #6422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
promotion-server
branch
5 times, most recently
from
2af2dda to
0197c8a
Compare
NejcZdovc
force-pushed
the
promotion-server
branch
from
0197c8a to
aaab482
Compare
zenparsing
reviewed
Aug 17, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/attestation/attestation_desktop.cc
Outdated
Show resolved
Hide resolved
| ConfirmCallback callback); | ||
|
|
||
| std::unique_ptr<endpoint::PromotionServer> promotion_server_; |
There was a problem hiding this comment.
Just an observation, but I don't think these need to be unique_ptrs - I think you could just have endpoint::PromotionServer.
vendor/bat-native-ledger/src/bat/ledger/internal/attestation/attestation_iosx.cc
Outdated
Show resolved
Hide resolved
| GetAvailable::~GetAvailable() = default; | ||
|
|
||
| std::string GetAvailable::GetUrl(const std::string& platform) { | ||
| const std::string payment_id = ledger_->state()->GetPaymentId(); |
There was a problem hiding this comment.
Just an observation: another option would be to take the payment ID as a parameter to Request. That would probably make these classes more testable, since there would be no need to mock out this payment ID in the ledger or ledger client level.
...ve-ledger/src/bat/ledger/internal/endpoint/promotion/get_recover_wallet/get_recover_wallet.h
Show resolved
Hide resolved
...or/bat-native-ledger/src/bat/ledger/internal/endpoint/promotion/post_captcha/post_captcha.cc
Outdated
Show resolved
Hide resolved
...or/bat-native-ledger/src/bat/ledger/internal/endpoint/promotion/post_captcha/post_captcha.cc
Outdated
Show resolved
Hide resolved
.../src/bat/ledger/internal/endpoint/promotion/post_suggestions_claim/post_suggestions_claim.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/promotion/promotion_server.h
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/wallet/wallet_claim.h
Outdated
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
promotion-server
branch
2 times, most recently
from
5264b09 to
cec8ef4
Compare
NejcZdovc
force-pushed
the
promotion-server
branch
from
cec8ef4 to
6baff0d
Compare
zenparsing
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#11203
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Check this paths:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.