Skip to content

Fixes claim for existing wallets #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Fixes claim for existing wallets #6384

merged 1 commit into from
Aug 11, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 10, 2020

Resolves brave/brave-browser#11144

Submitter Checklist:

Test Plan:

  • enable rewards
  • restore wallet with some ad grants
  • connect KYC wallet
  • make sure that funds are transferred to uphold

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Aug 10, 2020
@NejcZdovc NejcZdovc self-assigned this Aug 10, 2020
@NejcZdovc NejcZdovc marked this pull request as ready for review August 10, 2020 08:36
@NejcZdovc NejcZdovc requested review from a team, emerick and zenparsing and removed request for a team August 10, 2020 08:36
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc
Copy link
Contributor Author

CI failed on s3 upload for Windows, all good

@NejcZdovc
Copy link
Contributor Author

Windows CI failed on known things, all good

@NejcZdovc NejcZdovc merged commit 30f0c7e into master Aug 11, 2020
@NejcZdovc NejcZdovc deleted the claim-200 branch August 11, 2020 08:33
brave-builds pushed a commit that referenced this pull request Aug 17, 2020
NejcZdovc pushed a commit that referenced this pull request Aug 20, 2020
@LaurenWags
Copy link
Member

Verified passed with

Brave	1.15.6 Chromium: 85.0.4183.78 (Official Build) nightly (64-bit)
Revision	720ec01a54ea94d2d8b7a1d273e0fa89722fb11b-refs/branch-heads/4183@{#1603}
OS	macOS Version 10.14.6 (Build 18G3020)

Ad1

Ad2

Connected KYC'd Uphold wallet. Confirmed seeing the below in my logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Method: UrlMethod::POST
> Content: ...

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Result: Success
> HTTP Code: 200
> Body: null

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: ...

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: 

Confirmed ad grant BAT moved to Uphold:
Ad3
Ad4
Ad5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Claim doesn't work for existing wallets
4 participants