-
Notifications
You must be signed in to change notification settings - Fork 966
Fixes storage not persist after reset #6285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -24,8 +24,9 @@ const mergeReducers = (state: Rewards.State | undefined, action: any) => { | |||
|
|||
if (!state) { | |||
state = storage.defaultState | |||
storage.save(state) | |||
} else if (state !== startingState) { | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is where the problem was as we used save directly and then debounced save came after that and override it. So now we use debounce for this one as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified using
|
Resolves brave/brave-browser#11024
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.