Filter out HubSpot email trackers from query string #5554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarier
force-pushed
the
francois-hubspot-email-trackers-9019
branch
from
b3d7987 to
544a1af
Compare
iefremov
reviewed
May 15, 2020
| @@ -35,7 +35,10 @@ namespace { | |||
|
|
|||
| const std::string& GetQueryStringTrackers() { | |||
| static const base::NoDestructor<std::string> trackers(base::JoinString( | |||
| std::vector<std::string>({"fbclid", "gclid", "msclkid", "mc_eid"}), "|")); | |||
| std::vector<std::string>({"fbclid", "gclid", "msclkid", "mc_eid", | |||
| "_hsenc", "__hssc", "__hstc", "__hsfp", | |||
There was a problem hiding this comment.
I would be happy to also have an issue link here
There was a problem hiding this comment.
@iefremov Do you mean as comment at the end of the line?
Something like this?
"_hsenc", "__hssc", "__hstc", "__hsfp", // brave/brave-browser#9019
There was a problem hiding this comment.
What works best for you.
I prefer either full links or issues/9019 for ease of copypasting :)
iefremov
approved these changes
May 15, 2020
fmarier
force-pushed
the
francois-hubspot-email-trackers-9019
branch
from
544a1af to
75517c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#9019.
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Go to https://brave.com/?_hsenc=1 and confirm that the URL bar shows https://brave.com/ (no query string parameter).
Reviewer Checklist:
After-merge Checklist:
changes has landed on.