Fix crash in BraveStatsUpdater when computer wakes from suspend #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
approved these changes
Oct 2, 2018
bbondy
added a commit
that referenced
this pull request
Oct 2, 2018
Fix crash in BraveStatsUpdater when computer wakes from suspend
bbondy
added a commit
that referenced
this pull request
Oct 2, 2018
Fix crash in BraveStatsUpdater when computer wakes from suspend
emerick
reviewed
Oct 2, 2018
| if (simple_url_loader_->NetError() != net::OK || response_code < 200 || | ||
| response_code > 299) { | ||
| LOG(ERROR) << "Failed to send usage stats to update server" | ||
| << ", error: " << simple_url_loader_->NetError() | ||
| << ", response code: " << response_code | ||
| << ", payload: " << *response_body |
There was a problem hiding this comment.
@pilgrim-brave I guess this line was the root cause of the crash?
There was a problem hiding this comment.
No, the crash was earlier. If SimpleURLLoader received a network error with a large response body, it attempted to copy the entire body into a fixed length buffer to call the OnSimpleLoaderComplete callback function. With a large enough body, this crashed. Fix uses DownloadHeadersOnly to ignore the response body altogether.
There was a problem hiding this comment.
OK I see, thanks for catching that!
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#1116
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: