Skip to content

Fixes converted ads keep showing - 1.9.x #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 27, 2020

Uplift of #5381
Resolves brave/brave-browser#9436

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.9.x - Beta milestone Apr 27, 2020
@tmancey tmancey requested a review from a team April 27, 2020 22:20
@tmancey tmancey self-assigned this Apr 27, 2020
@tmancey tmancey force-pushed the issues/9436-1.9.x branch from 63ab6ee to ffe7b68 Compare May 4, 2020 21:59
@kjozwiak
Copy link
Member

kjozwiak commented May 4, 2020

@tmancey mind taking a look? Looks like init is failing on every platform after rebasing.

@kjozwiak
Copy link
Member

kjozwiak commented May 5, 2020

Looks like macOS failed on test-browser as per https://ci.brave.com/job/pr-brave-browser-issues-9436-1.9.x/2/execution/node/499/log/.

04:19:27  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6247 ms)
04:19:27  [543/543] BraveRewardsBrowserTest.NotVerifiedWallet (6594 ms)
04:19:27  1 test failed:
04:19:27      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2326)

Known issue that will be fixed via brave/brave-browser#9339 which doesn't block uplift.

macOS also failed test-install as per https://ci.brave.com/job/pr-brave-browser-issues-9436-1.9.x/2/execution/node/521/log/.

This is also a known issue which isn't blocking uplift and will be addressed via brave/brave-browser#9480.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.9.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on Nightly as per #5381 (comment). Ensured that the issue was moved into the correct milestone.

@kjozwiak kjozwiak merged commit 5c344ac into 1.9.x May 5, 2020
@kjozwiak kjozwiak deleted the issues/9436-1.9.x branch May 5, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants