Skip to content

Adds check for empty token prefs on successful revocation (Binance widget) #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 24, 2020

Fixes: brave/brave-browser#9438

Submitter Checklist:

Test Plan:

Run npm run test -- brave_browser_tests --filter=BinanceAPIBrowserTest.* and ensure all tests pass.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added the tests label Apr 24, 2020
@ryanml ryanml added this to the 1.10.x - Nightly milestone Apr 24, 2020
@ryanml ryanml requested review from diracdeltas and bbondy April 24, 2020 05:06
@ryanml ryanml self-assigned this Apr 24, 2020
@ryanml
Copy link
Contributor Author

ryanml commented Apr 24, 2020

This update has been cherry-picked in to: #5353 and will be merged as part of that change. Closing this PR

@ryanml ryanml closed this Apr 24, 2020
@ryanml ryanml deleted the fix-9438 branch April 24, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check to ensure token pref wipe on successful revocation (Binance widget)
2 participants