Skip to content

Reflect referrals service change to ntp background images service #5283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 18, 2020

Issue brave/brave-browser#8218

As referrals service uses new prefs(kReferralInitialization) for
checking its initialization after merging #5238,
NTP services should check this status together with old prefs(kReferralCheckedForPromoCodeFile).
With #5238,
Referrals service set initialization status to kReferralInitialization only.

To detect the referrals service changes in the future, added me to
OWNERS file.

Submitter Checklist:

Test Plan:

npm run test brave_unit_tests -- --filter= NTPBackgroundImagesServiceTest*

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.9.x - Nightly milestone Apr 18, 2020
@simonhong simonhong requested a review from bsclifton April 18, 2020 00:26
@simonhong simonhong self-assigned this Apr 18, 2020
@simonhong simonhong force-pushed the ntp_super_referral_images2 branch from 4c0ceb5 to 4366206 Compare April 18, 2020 00:52
As referrals service uses new prefs(kReferralInitialization) for
checking its initialization, NTP services should check this status
together with old prefs(kReferralCheckedForPromoCodeFile).

To detect the referrals service changes in the future, added me to
OWNERS file.
@simonhong simonhong force-pushed the ntp_super_referral_images2 branch from 4366206 to 84a226e Compare April 18, 2020 14:29
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 👍

@simonhong
Copy link
Member Author

Merged because BraveRewardsBrowserTest.NotVerifiedWallet is failed but it's flaky now and only failed on macOS. That test is passed on other platforms.

@simonhong simonhong merged commit eff3b05 into master Apr 21, 2020
@simonhong simonhong deleted the ntp_super_referral_images2 branch April 21, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants