Reflect referrals service change to ntp background images service #5283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue brave/brave-browser#8218
As referrals service uses new prefs(kReferralInitialization) for
checking its initialization after merging #5238,
NTP services should check this status together with old prefs(kReferralCheckedForPromoCodeFile).
With #5238,
Referrals service set initialization status to kReferralInitialization only.
To detect the referrals service changes in the future, added me to
OWNERS file.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
npm run test brave_unit_tests -- --filter= NTPBackgroundImagesServiceTest*
Reviewer Checklist:
After-merge Checklist:
changes has landed on.