Skip to content

Changed closing app on closing all tabs behavior to match android tabs (uplift to 1.7.x) #5169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Changed closing app on closing all tabs behavior to match android tabs (uplift to 1.7.x) #5169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions android/java/org/chromium/chrome/browser/partnercustomizations/CloseBraveManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,7 @@
public class CloseBraveManager {
private static final String CLOSING_ALL_TABS_CLOSES_BRAVE = "closing_all_tabs_closes_brave";

// When NTP is set as home page, we don't close brave always.
// Otherwise, follow option value.
public static boolean shouldCloseAppWithZeroTabs() {
if (HomepageManager.isHomepageEnabled() &&
NewTabPage.isNTPUrl(HomepageManager.getHomepageUri())) {
return false;
}

return getClosingAllTabsClosesBraveEnabled();
}

Expand Down