Skip to content

Changed closing app on closing all tabs behavior to match android tabs (uplift to 1.8.x) #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

Changed closing app on closing all tabs behavior to match android tabs (uplift to 1.8.x) #5168

merged 1 commit into from
Apr 7, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 6, 2020 •
edited by kjozwiak
Loading

Uplift of #5164

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Apr 6, 2020
@brave-builds brave-builds added this to the 1.8.x - Beta milestone Apr 6, 2020
@samartnik samartnik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 7, 2020

QA verified that the above PR worked on the latest Nightly as per #5164 (comment).

kjozwiak
kjozwiak approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit df4d5d8 into 1.8.x Apr 7, 2020
@kjozwiak kjozwiak deleted the pr5164_android_close_all_tabs_close_brave_fix_1.8.x branch April 7, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @samartnik @brave-browser-releases