Skip to content

Modify Sync UI to allow only one device in chain #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

Modify Sync UI to allow only one device in chain #4407

merged 1 commit into from
Jan 24, 2020

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jan 22, 2020 •
edited by bsclifton
Loading

Uplift request for #4239

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

@cezaraugusto
Merge pull request #4239 from brave/ca-6941
c9b92e4 
Modify Sync UI to allow only one device in chain
@cezaraugusto cezaraugusto requested a review from a team January 22, 2020 17:43
@cezaraugusto cezaraugusto self-assigned this Jan 22, 2020
@cezaraugusto cezaraugusto added this to the 1.4.x - Dev milestone Jan 22, 2020
@kjozwiak
Copy link
Member

Restarting. Seems like it never really started and timed out after ~6mins.

@kjozwiak
Copy link
Member

Restarting iOS due to https://ci.brave.com/job/brave-browser-build-pr/job/ca-6941-1.4/1/execution/node/115/log/ failing.

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/ca-6941-1.4/1/execution/node/600/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Jan 23, 2020
@kjozwiak
Copy link
Member

Looks like it failed to fetch the repo on macOS as per https://ci.brave.com/job/brave-browser-build-pr/job/ca-6941-1.4/2/execution/node/292/log/. Going to restart macOS and see if that helps.

@kjozwiak kjozwiak added the CI/skip-ios Do not run CI builds for iOS label Jan 23, 2020
kjozwiak
kjozwiak approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. @btlechowski also went through the PR as per #4239 (comment). @AlexeyBarabash also confirmed that brave/brave-browser#7893 was cause by #4324 and not #4239.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit a9af078 into 1.4.x Jan 24, 2020
@kjozwiak kjozwiak deleted the ca-6941-1.4 branch January 24, 2020 22:29
This was referenced Jan 24, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/sync
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@cezaraugusto @kjozwiak