Skip to content

Upgrade from Chromium 79.0.3945.74 to Chromium 79.0.3945.79 #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2019
Merged

Upgrade from Chromium 79.0.3945.74 to Chromium 79.0.3945.79 #4207

merged 2 commits into from
Dec 12, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 10, 2019 •
edited
Loading

Fixes brave/brave-browser#7314
Related PR: brave/brave-browser#7320

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.4.x - Nightly milestone Dec 10, 2019
@mkarolin mkarolin requested a review from bridiver as a code owner December 10, 2019 20:49
@mkarolin mkarolin self-assigned this Dec 10, 2019
@mkarolin mkarolin mentioned this pull request Dec 10, 2019
Merged
28 tasks
bsclifton
bsclifton approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin force-pushed the 79.0.3945.79 branch 2 times, most recently from 509786f to acffb09 Compare December 10, 2019 23:30
@mkarolin mkarolin added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 11, 2019
@mkarolin @bsclifton
Update patches from Chromium 79.0.3945.74 to Chromium 79.0.3945.79
1178018
@mkarolin @bsclifton
Updated BraveBottomToolbarCoordinator c'tor signature.
02cfb33 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/45cce5fc1f2c2a8f64aceee1e3f97265a21abf9d

commit 45cce5fc1f2c2a8f64aceee1e3f97265a21abf9d
Author: Lijin Shen <[email protected]>
Date:   Thu Oct 31 23:03:39 2019 +0000

    Add tab switcher longpress menu on bottom toolbar

    Implemented the tab swithcer longpress menu on the bottom.
    In the meanwhile, decreased the menu width to match the design spec.

    Bug: 1011012
@bsclifton bsclifton merged commit 4a2f52f into master Dec 12, 2019
@bsclifton bsclifton deleted the 79.0.3945.79 branch December 12, 2019 16:26
mkarolin pushed a commit that referenced this pull request Dec 12, 2019
@bsclifton @mkarolin
Merge pull request #4207 from brave/79.0.3945.79
31e77a0 
Upgrade from Chromium 79.0.3945.74 to Chromium 79.0.3945.79
mkarolin pushed a commit that referenced this pull request Dec 12, 2019
@bsclifton @mkarolin
Merge pull request #4207 from brave/79.0.3945.79
2ff942a 
Upgrade from Chromium 79.0.3945.74 to Chromium 79.0.3945.79
mkarolin pushed a commit that referenced this pull request Dec 12, 2019
@bsclifton @mkarolin
Merge pull request #4207 from brave/79.0.3945.79
57bc66f 
Upgrade from Chromium 79.0.3945.74 to Chromium 79.0.3945.79
This was referenced Dec 12, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@mkarolin mkarolin

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 79.0.3945.74 to Chromium 79.0.3945.79
2 participants
@mkarolin @bsclifton