Skip to content

Add missing copyright symbol #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Nov 5, 2019

Fixes brave/brave-browser#4990. Script changes in brave/brave-browser#6771.

This also fixes a "Brave LLC" string in the copyright notice.

Submitter Checklist:

Test Plan:

On Desktop, open chrome://settings/help and check that the copyright symbol (C) is present and that it says "The Brave Authors" instead of "Brave Software Inc".

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier force-pushed the francois-missing-copyright-symbol-4990-bc2 branch from c39a279 to d7c50f0 Compare November 21, 2019 00:18
@fmarier fmarier requested a review from petemill November 21, 2019 18:53
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ AS per brave/brave-browser#6771:

If there's an issue with the copyright symbol in transifex on the next upload then we can re-think or adjust the transifex scripts. Should be ok though! cc @mkarolin

@petemill petemill merged commit 4e9d6a0 into master Nov 25, 2019
@petemill petemill deleted the francois-missing-copyright-symbol-4990-bc2 branch November 25, 2019 16:29
@fmarier fmarier modified the milestones: 1.2.x - Dev, 1.3.x - Nightly Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copyright (c) symbol in About Brave
2 participants