Skip to content

Add content script to build file #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Add content script to build file #373

merged 1 commit into from
Aug 30, 2018

Conversation

Snuupy
Copy link
Contributor

@Snuupy Snuupy commented Aug 30, 2018

Status:
Done and working
waiting for travis CI build
waiting on a local build of brave-browser to complete for testing.

Submitter Checklist:

Test Plan:

  1. npm run build && npm run start
  2. right click context menu to make sure you can block elements through CSS selectors

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@Snuupy Snuupy self-assigned this Aug 30, 2018
@Snuupy Snuupy changed the title WIP: add content script to build file WIP: Add content script to build file Aug 30, 2018
@Snuupy Snuupy changed the title WIP: Add content script to build file Add content script to build file Aug 30, 2018
@bbondy bbondy merged commit 438fcef into brave:master Aug 30, 2018
@Snuupy Snuupy deleted the cosmeticFilter branch August 30, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants