-
Notifications
You must be signed in to change notification settings - Fork 981
Implement SOCKS5 authentication. #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Work around Chromium's new in-line constructor size limits. - Get base::StringPiece forward declaration in url_auth_util.h. - Use `#if !defined(BRAVE_CHROMIUM_BUILD)', not #if 0. - Override and include, rather than patch, net_log_event_type_list.h. - Override and include host_port_pair.cc to reduce BUILD.gn diffs. - Override and include url_util.cc rather than add url_auth_util.cc. - Override and include socks5_client_socket.cc. - Don't patch HostPortPair(host, port) constructor. Instead, use a different constructor in proxy_server.cc. This adds another patch to our maintenance burden, but it avoids changing the semantics of (and adding parsing overhead to) the constructor that is used in a bazillion places all over Chromium.
build pass on all platforms. However,
Crash stacks are almost the same cause
|
the above error turns out to be causing by sccache. |
All build pass, |
Add --disable_pdfjs_extension switch
Work around Chromium's new in-line constructor size limits.
Get base::StringPiece forward declaration in url_auth_util.h.
Use `#if !defined(BRAVE_CHROMIUM_BUILD)', not #if 0.
Override and include, rather than patch, net_log_event_type_list.h.
Override and include host_port_pair.cc to reduce BUILD.gn diffs.
Override and include url_util.cc rather than add url_auth_util.cc.
Override and include socks5_client_socket.cc.
Don't patch HostPortPair(host, port) constructor.
Instead, use a different constructor in proxy_server.cc.
This adds another patch to our maintenance burden, but it avoids
changing the semantics of (and adding parsing overhead to) the
constructor that is used in a bazillion places all over Chromium.
This is a replacement for #290, in which during squashing or something I lost two files (socks5_client_socket.cc/h) that were critical to the whole thing, and for #302, which was behind a Chromium update or something, and for #311, which had a larger set of patches than necessary.
fix brave/brave-browser#666
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
On riastradh-socks5-auth-test-v3 (which only adds tests, doesn't touch anything used outside tests):
ninja -C src/out/Debug net:net_unittests
./src/out/Debug/net_unittests --gtest_filter='ProxyServerTest.*:SOCKS5ClientSocketTest.*'
Reviewer Checklist: