Skip to content

[iOS] Fix missing toggle switch for 'Always request desktop mode' pref #29391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

[iOS] Fix missing toggle switch for 'Always request desktop mode' pref #29391

merged 1 commit into from
Jun 4, 2025

Conversation

kylehickinson
Copy link
Collaborator

This switch was accidentally missed when migrating the underlying setting to use Chromium's host content settings

Resolves brave/brave-browser#46484

@kylehickinson
[iOS] Fix missing toggle switch for 'Always request desktop mode' pref
65f4c52 
This switch was accidentally missed when migrating the underlying setting to use Chromium's host content settings
@kylehickinson kylehickinson self-assigned this Jun 4, 2025
@kylehickinson kylehickinson requested a review from a team as a code owner June 4, 2025 15:50
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Jun 4, 2025
@kylehickinson kylehickinson enabled auto-merge (squash) June 4, 2025 16:25
@kylehickinson kylehickinson merged commit f6dead6 into master Jun 4, 2025
19 checks passed
@kylehickinson kylehickinson deleted the ios-always-request-desktop-fix branch June 4, 2025 17:14
@github-actions github-actions bot added this to the 1.81.x - Nightly milestone Jun 4, 2025
brave-builds added a commit that referenced this pull request Jun 4, 2025
@brave-builds
Uplift of #29391 (squashed) to beta
5080ce7
@brave-builds brave-builds mentioned this pull request Jun 4, 2025
Merged
7 tasks
@brave-builds
Copy link
Collaborator

Released in v1.81.47

@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 5, 2025 •
edited
Loading

Verified on iPad (9th Gen) running iPadOS 18.5 using version 1.81 (51)

  • ensured that Always Request Desktop Site toggle is shown in the settings menu
  • ensured that enabling Always Request Desktop Site will always load desktop site
  • ensured that mobile sites are still loaded after disabling the setting
  • ensured the setting toggle is shown and can be enabled after upgrading the app (1.80.x -> 1.81.51)
example example example example
Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHeaps StephenHeaps StephenHeaps approved these changes

Assignees

@kylehickinson kylehickinson

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.81.x - Nightly
Development

Successfully merging this pull request may close these issues.

Brave Beta iPad 1.80(95) Always desktop toggle broken
4 participants
@kylehickinson @brave-builds @Uni-verse @StephenHeaps