Skip to content

Prettier for /components/brave_wallet_ui/panel #29365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Jun 3, 2025

@supermassive supermassive requested a review from a team as a code owner June 3, 2025 06:09
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jun 3, 2025
Copy link
Contributor

github-actions bot commented Jun 3, 2025

[puLL-Merge] - brave/brave-core@29365

Description

This PR applies Prettier code formatting to several directories in the Brave Wallet UI codebase. The changes remove these directories from the .prettierignore file and apply consistent formatting across TypeScript/JavaScript files including:

  • Adding trailing commas to object properties, function parameters, and array elements
  • Converting string concatenation using + operator to template literals
  • Fixing indentation and line breaks for better readability
  • Ensuring consistent spacing and formatting throughout the codebase

The changes are purely cosmetic formatting improvements with no functional modifications to the code logic.

Changes

Changes

.prettierignore

  • Removed exclusions for /components/brave_wallet_ui/market/, /components/brave_wallet_ui/mocks/, /components/brave_wallet_ui/nft/, and /components/brave_wallet_ui/stories/ directories

components/brave_wallet_ui/market/

  • Added trailing commas to enum values, function parameters, and object properties
  • Fixed line formatting and indentation

components/brave_wallet_ui/mocks/

  • Converted string concatenation to template literals
  • Added trailing commas to object properties

components/brave_wallet_ui/nft/

  • Added trailing commas throughout object definitions and imports
  • Improved formatting consistency

components/brave_wallet_ui/stories/

  • Extensive formatting improvements including trailing commas
  • Converted multi-line string concatenation to template literals
  • Fixed indentation and spacing consistency
  • Updated mock data formatting for better readability
graph LR
    A[Developer] --> B[Remove directories from .prettierignore]
    B --> C[Run Prettier formatting]
    C --> D[Apply formatting rules]
    D --> E{File type?}
    E -->|TypeScript/JavaScript| F[Add trailing commas]
    E -->|TypeScript/JavaScript| G[Convert string concatenation]
    E -->|TypeScript/JavaScript| H[Fix indentation]
    F --> I[Formatted files]
    G --> I
    H --> I
    I --> J[Commit changes]
Loading

@brave-builds
Copy link
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

Found 4 lines longer than 80 characters (first 5 shown).

Items:

components/brave_wallet_ui/stories/locale.ts, line 1421, 81 chars
components/brave_wallet_ui/stories/locale.ts, line 1486, 83 chars
components/brave_wallet_ui/stories/mock-data/mock-nft-metadata.ts, line 129, 126 chars
components/brave_wallet_ui/stories/mock-data/mock-nft-metadata.ts, line 130, 235 chars

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@supermassive supermassive merged commit a16df0b into master Jun 4, 2025
19 checks passed
@supermassive supermassive deleted the prettier_brave_wallet_ui_panel branch June 4, 2025 03:15
@github-actions github-actions bot added this to the 1.81.x - Nightly milestone Jun 4, 2025
@brave-builds
Copy link
Collaborator

Released in v1.81.45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable prettier for components/brave_wallet_ui/panel
3 participants