[ads] Survey panelist: Android #29360

aseren · 2025-06-03T00:12:12Z

The PR adds Allow Brave surveys setting in Android settings:

Resolves brave/brave-browser#45992

Test case 1

Start browser with BraveNTPBrandedWallpaperSurveyPanelist feature disabled
Open Privacy and security settings
EXPECTATION: Allow Brave surveys setting is not available

Test case 2

Start browser with BraveNTPBrandedWallpaperSurveyPanelist feature enabled
Open Privacy and security settings
EXPECTATION: Allow Brave surveys setting is disabled by default
Click to Learn more about Brave surveys link
EXPECTATION: Brave surveys help page is opened

brave-builds · 2025-06-03T00:30:25Z

Warning

You have got a presubmit warning. Please address it if possible.

Found 1 lines longer than 80 characters (first 5 shown).

Items:

android/java/res/xml/brave_privacy_preferences.xml, line 192, 88 chars

brave-builds · 2025-06-03T00:30:26Z

Warning

You have got a presubmit warning. Please address it if possible.

-------------------------
[Warning] chromium_src:
  Ignoring symbol BRAVE_AI_CHAT_FLAGS:
  Symbol is used internally in chromium_src/chrome/browser/flags/android/chrome_feature_list.cc
  Symbol is NOT found in /home/ubuntu/workspace/ore-build-pr-noplatform_PR-29360/src/chrome/browser/flags/android/chrome_feature_list.cc.

brave-builds · 2025-06-03T00:30:27Z

Warning

You have got a presubmit warning. Please address it if possible.

-------------------------
[Warning] chromium_src:
  Ignoring symbol BRAVE_WEB_DISCOVERY_FLAG:
  Symbol is used internally in chromium_src/chrome/browser/flags/android/chrome_feature_list.cc
  Symbol is NOT found in /home/ubuntu/workspace/ore-build-pr-noplatform_PR-29360/src/chrome/browser/flags/android/chrome_feature_list.cc.

brave-builds · 2025-06-03T00:30:28Z

Warning

You have got a presubmit warning. Please address it if possible.

-------------------------
[Warning] chromium_src:
  Ignoring symbol BRAVE_WEB_DISCOVERY_FLAG:
  Symbol is used internally in chromium_src/chrome/browser/flags/android/chrome_feature_list.cc
  Symbol is NOT found in /home/ubuntu/workspace/ore-build-pr-noplatform_PR-29360/src/chrome/browser/flags/android/chrome_feature_list.cc.

tmancey · 2025-06-03T12:15:32Z

android/java/org/chromium/base/BraveFeatureList.java

@@ -39,4 +39,5 @@ public abstract class BraveFeatureList {
    public static final String BRAVE_SHIELDS_ELEMENT_PICKER = "BraveShieldsElementPicker";
    public static final String BRAVE_WEB_DISCOVERY_NATIVE = "BraveWebDiscoveryNative";
    public static final String BRAVE_INCOGNITO_SCREENSHOT = "incognito-screenshot";
+    public static final String BRAVE_SURVEY_PANELIST = "BraveNTPBrandedWallpaperSurveyPanelist";


nit: Match string to variable name

tmancey · 2025-06-03T12:18:49Z

android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java

@@ -174,6 +180,7 @@ public class BravePrivacySettings extends PrivacySettings {
        PREF_SEND_P3A,
        PREF_SEND_CRASH_REPORTS,
        PREF_BRAVE_STATS_USAGE_PING,
+        PREF_BRAVE_SURVEY_PANELIST,


nit: Do we need brave in the name?

Not needed, removed.

tmancey · 2025-06-03T12:20:24Z

android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java

@@ -104,6 +107,9 @@ public class BravePrivacySettings extends PrivacySettings {
    private static final String PREF_SEND_P3A = "send_p3a_analytics";
    private static final String PREF_SEND_CRASH_REPORTS = "send_crash_reports";
    private static final String PREF_BRAVE_STATS_USAGE_PING = "brave_stats_usage_ping";
+    private static final String PREF_BRAVE_SURVEY_PANELIST = "brave_survey_panelist";
+    private static final String PREF_BRAVE_SURVEY_PANELIST_LEARN_MORE =


nit: Do we need brave in the name?

Not needed, removed.

tmancey · 2025-06-03T12:21:19Z

android/java/res/xml/brave_privacy_preferences.xml

          android:title="@string/send_crash_reports_title"
          android:summary="@string/send_crash_reports_summary"
          android:defaultValue="false" />
        <org.chromium.components.browser_ui.settings.ChromeSwitchPreference
            android:key="brave_stats_usage_ping"
-            android:order="25"


Were these intentionally removed?

Yes these wee intentionally removed, as they broke order of new preference items.
Also android:order attributes did nothing here before because they all had the same value.

tmancey · 2025-06-03T12:22:28Z

browser/ui/android/strings/android_brave_strings.grd

@@ -774,6 +774,15 @@ This file contains all "about" strings.  It is set to NOT be translated, in tran
      <message name="IDS_BRAVE_STATS_TEXT_TIME" desc="Title for the estimated saved time">
        Est. Time\nSaved
      </message>
+      <message name="IDS_BRAVE_SURVEY_PANELIST_TITLE" desc="Title for enable/disable brave survey panelist toggle.">


Do we need brave in the name? Same for below

Not needed, removed.

SergeyZhukovsky · 2025-06-03T14:10:08Z

android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java

@@ -592,6 +623,11 @@ public boolean onPreferenceChange(Preference preference, Object newValue) {
                    (boolean) newValue, ChangeMetricsReportingStateCalledFrom.UI_SETTINGS);
        } else if (PREF_BRAVE_STATS_USAGE_PING.equals(key)) {
            BraveLocalState.get().setBoolean(BravePref.STATS_REPORTING_ENABLED, (boolean) newValue);
+        } else if (PREF_BRAVE_SURVEY_PANELIST.equals(key)) {
+            UserPrefs.get(ProfileManager.getLastUsedRegularProfile())


use getProfile(). We are going to refactor other places inside BravePrivacySettings later.

SergeyZhukovsky · 2025-06-03T14:10:14Z

android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java

@@ -784,6 +820,10 @@ private void updateBravePreferences() {
        mBraveStatsUsagePing.setChecked(
                BraveLocalState.get().getBoolean(BravePref.STATS_REPORTING_ENABLED));

+        mBraveSurveyPanelist.setChecked(
+                UserPrefs.get(ProfileManager.getLastUsedRegularProfile())


getProfile()

SergeyZhukovsky

++

mkarolin

chromium_src, DEPS, strings++

brave-builds · 2025-06-04T18:31:28Z

Released in v1.81.47

aseren requested review from a team as code owners June 3, 2025 00:12

github-actions bot assigned aseren Jun 3, 2025

aseren requested review from tmancey and iambrianfung June 3, 2025 00:13

aseren marked this pull request as draft June 3, 2025 00:17

aseren force-pushed the issues/45992 branch from da4606f to d03f7d4 Compare June 3, 2025 00:40

aseren marked this pull request as ready for review June 3, 2025 01:27

tmancey requested changes Jun 3, 2025

View reviewed changes

SergeyZhukovsky reviewed Jun 3, 2025

View reviewed changes

aseren force-pushed the issues/45992 branch from d03f7d4 to aad510b Compare June 3, 2025 16:39

SergeyZhukovsky approved these changes Jun 3, 2025

View reviewed changes

aseren requested a review from tmancey June 3, 2025 16:59

tmancey approved these changes Jun 3, 2025

View reviewed changes

mkarolin approved these changes Jun 3, 2025

View reviewed changes

aseren force-pushed the issues/45992 branch from aad510b to 0c8586d Compare June 3, 2025 21:21

[ads] Survey panelist: Android

2115662

aseren force-pushed the issues/45992 branch from 0c8586d to 2115662 Compare June 3, 2025 23:40

aseren merged commit 5652fe9 into master Jun 4, 2025
18 checks passed

aseren deleted the issues/45992 branch June 4, 2025 14:04

github-actions bot added this to the 1.81.x - Nightly milestone Jun 4, 2025

[ads] Survey panelist: Android #29360

[ads] Survey panelist: Android #29360

Uh oh!

Conversation

aseren commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test case 1

Test case 2

Uh oh!

brave-builds commented Jun 3, 2025

Uh oh!

brave-builds commented Jun 3, 2025

Uh oh!

brave-builds commented Jun 3, 2025

Uh oh!

brave-builds commented Jun 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SergeyZhukovsky left a comment

Choose a reason for hiding this comment

Uh oh!

mkarolin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brave-builds commented Jun 4, 2025

Uh oh!

Uh oh!

aseren commented Jun 3, 2025 •

edited

Loading