Make build_crate use root_out_dir as its temp.
#29353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Jun 4, 2025
tools/crates/build_crate.gni
Outdated
| @@ -36,6 +36,8 @@ template("build_crate") { | |||
| # --frozen (--locked + --offline) | |||
| # when running `cargo build`. | |||
| args = [ | |||
| "--temp_dir_path", | |||
| rebase_path(root_out_dir), | |||
There was a problem hiding this comment.
I would either use target_out_dir here or give it some path within root_out_dir. This also needs to be in the outputs list to ensure that there are no conflicts with outputs from other targets.
I also noticed below that there are unlisted inputs here like Cargo.toml and .cargo/config.toml and I'm a bit concerned that other artifacts are left in target_dir that are not listed as outputs and may therefore also conflict. I don't think it's a good idea to have any of these outputs in the root out dir for exactly this reason.
There was a problem hiding this comment.
also it should generate a depfile with --emit=dep-info
https://gn.googlesource.com/gn/+/main/docs/reference.md#var_depfile
szilardszaloki
force-pushed
the
szilard/46505-build_crate-temp-dir
branch
from
113c3d6 to
568a52a
Compare
bridiver
approved these changes
Jun 5, 2025
|
Released in v1.81.56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#46505.