Import lock dialog now modal. Import profiles button state fixed. #29341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
goodov
approved these changes
Jun 4, 2025
|
Released in v1.81.45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#46475
Resolved brave/brave-browser#46563
Before:
The lock dialog from Google isn't modal. Additionally, the "Import profile" button in the onboarding UI remains clickable during an active import. Together, these issues allow users to initiate multiple imports simultaneously.
Now:
The lock dialog is now modal, appearing above the browser window. The
Importbutton state dynamically updates to reflect the current import status.import_fix.mp4
Whale has own extensions store, so some extensions can't be imported, the second attempt to import the same profile led to the crash because of a bug. Fixed:
whale.mp4