Skip to content

fix(iOS): fix wrong QSE launched if Leo is disabled. #29338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

fix(iOS): fix wrong QSE launched if Leo is disabled. #29338

merged 1 commit into from
Jun 2, 2025

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Jun 2, 2025 •
edited
Loading

@nuo-xu nuo-xu self-assigned this Jun 2, 2025
@nuo-xu nuo-xu added the CI/skip-android Do not run CI builds for Android label Jun 2, 2025
@nuo-xu nuo-xu requested a review from a team as a code owner June 2, 2025 03:28
@nuo-xu nuo-xu added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Jun 2, 2025
@nuo-xu nuo-xu merged commit 38811b8 into master Jun 2, 2025
19 checks passed
@nuo-xu nuo-xu deleted the bugfix/46421 branch June 2, 2025 14:54
@github-actions github-actions bot added this to the 1.81.x - Nightly milestone Jun 2, 2025
brave-builds added a commit that referenced this pull request Jun 2, 2025
@brave-builds
Uplift of #29338 (squashed) to beta
02b260c
brave-builds added a commit that referenced this pull request Jun 2, 2025
@brave-builds
Uplift of #29338 (squashed) to release
b189e1a
This was referenced Jun 2, 2025
Merged
Merged
@brave-builds
Copy link
Collaborator

Released in v1.81.38

@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2025

Verification PASSED on iPhone 11 running iOS 18.4.1 using the following build(s):

Brave | 1.81.41 Chromium: 137.0.7151.68 (Official Build) nightly (64-bit) 
--- | ---
Revision | a33b42c5dda6...
OS | iOS

Using the STR/Cases outlined via brave/brave-browser#46421 (comment), ensured that the correct QSE is being used once Leo has been disabled/removed from QSE as per the following:

ScreenRecording_06-03-2025.12-27-38_1.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@nuo-xu nuo-xu

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.81.x - Beta
Development

Successfully merging this pull request may close these issues.

Quick-search engine order is offset in the scroll view when disabling Leo quick-search
4 participants
@nuo-xu @brave-builds @kjozwiak @kylehickinson