Remove Mixtral from model choices #29291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
approved these changes
May 28, 2025
Brandon-T
approved these changes
May 28, 2025
Brandon-T
requested changes
May 28, 2025
| @@ -393,9 +389,6 @@ extension AiChat.Model { | |||
| case .chatBasic: | |||
| return Strings.AIChat.introMessageLlamaModelPurposeDescription | |||
|
|
|||
| case .chatExpanded: | |||
| return Strings.AIChat.introMessageMixtralModelPurposeDescription | |||
There was a problem hiding this comment.
We should delete these:
and:
and update:
There was a problem hiding this comment.
First one was already removed but I removed the 2nd and removed the sentence mentioning the default model completely for the third 50388a9
Brandon-T
approved these changes
May 28, 2025
Other uses of chat-deafult will newly be migrated to automatic, but people are probably already migrated at this point for that one
So that it doesn't look like a user specified pref. And because iOS doesn't support automatic yet.
|
Released in v1.81.35 |
brave-builds
added a commit
that referenced
this pull request
Jun 4, 2025
7 tasks
|
Verification passed on
29291.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#46406