Skip to content

[Android] Main settings reorganisation #29086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

[Android] Main settings reorganisation #29086

merged 1 commit into from
May 15, 2025
+11 −19

Conversation

samartnik
Copy link
Contributor

  • Renamed Autofill section to Passwords and Autofill
  • Moved Brave Password Manager and Autofill services to the new section

Resolves brave/brave-browser#46082

@samartnik
[Android] Main settings reorganisation
2655016 
- Renamed `Autofill` section to `Passwords and Autofill`
- Moved `Brave Password Manager` and `Autofill services` to the new section
@samartnik samartnik added this to the 1.80.x - Nightly milestone May 15, 2025
@samartnik samartnik self-assigned this May 15, 2025
@samartnik samartnik requested review from a team as code owners May 15, 2025 17:48
@samartnik samartnik added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels May 15, 2025
@samartnik
Copy link
Contributor Author

New section look

Screenshot_20250515_131740

@github-actions GitHub Actions
Copy link
Contributor

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

@samartnik samartnik mentioned this pull request May 15, 2025
Merged
SergeyZhukovsky
SergeyZhukovsky approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented May 15, 2025 •
edited
Loading

I wonder if https://github.com/brave/brave-core/blob/master/android/javatests/org/chromium/chrome/browser/settings/BraveMainSettingsFragmentTest.java requires to be updated?

@samartnik
Copy link
Contributor Author

@AlexeyBarabash it was updated, or something else should be done?

@AlexeyBarabash
Copy link
Contributor

@samartnik , sorry, it was indeed. I missed that somehow.

mkarolin
mkarolin approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@samartnik samartnik merged commit 8fd36b6 into master May 15, 2025
19 checks passed
@samartnik samartnik deleted the android_main_settings_reorg branch May 15, 2025 20:20
@brave-builds
Copy link
Collaborator

Released in v1.80.72

mkarolin pushed a commit that referenced this pull request May 16, 2025
@samartnik @mkarolin
[Android] Main settings reorganisation (#29086)
ddedc39 
- Renamed `Autofill` section to `Passwords and Autofill`
- Moved `Brave Password Manager` and `Autofill services` to the new section
@mkarolin mkarolin mentioned this pull request May 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@mkarolin mkarolin mkarolin approved these changes

Assignees

@thypon thypon

@kdenhartog kdenhartog

@samartnik samartnik

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.80.x - Beta
Development

Successfully merging this pull request may close these issues.

[Cr137] Need to rename Autofill section to Passwords and Autofill move Brave password manager and Autofill services there
7 participants
@samartnik @AlexeyBarabash @brave-builds @SergeyZhukovsky @mkarolin @thypon @kdenhartog