Fix perf issue with regex_automata #28748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
requested changes
Apr 21, 2025
atuchin-m
force-pushed
the
fix-regex-automata-perf-issue
branch
from
6988d87 to
9a0da4d
Compare
atuchin-m
force-pushed
the
fix-regex-automata-perf-issue
branch
from
9a0da4d to
50f9963
Compare
bridiver
approved these changes
Apr 21, 2025
|
Released in v1.79.84 |
mkarolin
pushed a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#45564
Removed chromium features: https://chromium-review.googlesource.com/c/chromium/src/+/6384041/4/third_party/rust/regex_automata/v0_4/BUILD.gn
A local static build and profiling data confirms that the issue is resolved:
