Skip to content

[iOS] - Fix download filename. Fix download host. (uplift to 1.78.x) #28727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2025
Merged

[iOS] - Fix download filename. Fix download host. (uplift to 1.78.x) #28727

merged 1 commit into from
Apr 19, 2025
+15 −7

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Apr 17, 2025 •
edited by kjozwiak
Loading

Uplift of #28656
Resolves brave/brave-browser#45433

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Brandon-T
[iOS] - Fix download filename. Fix download host. (#28656)
6e6b343 
* Strip BidiControl from download file name
* Fix downloads not working for data URIs
* Remove data-uri check. Just don't display any host if there is none (following Safari and Chrome)
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Apr 17, 2025
@Brandon-T Brandon-T self-assigned this Apr 17, 2025
@Brandon-T Brandon-T requested a review from a team as a code owner April 17, 2025 18:53
@kjozwiak kjozwiak added this to the 1.78.x - Beta milestone Apr 19, 2025
kjozwiak
kjozwiak approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.78.x approved 👍 QA has verified the PR on Nightly using 1.79.x as per #28656 (comment).

@kjozwiak kjozwiak merged commit 8699544 into 1.78.x Apr 19, 2025
17 checks passed
@kjozwiak kjozwiak deleted the bugfix/DownloadSuggestedFileName-1.78.x branch April 19, 2025 17:39
@brave-builds
Copy link
Collaborator

Released in v1.78.86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.78.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Brandon-T @brave-builds @kjozwiak