Skip to content

Fixed crash when send tabs to desktop #28498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Fixed crash when send tabs to desktop #28498

merged 1 commit into from
Apr 4, 2025

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 4, 2025 •
edited
Loading

fix brave/brave-browser#45198

Enabled related upstream test cases.

Resolves

@simonhong simonhong self-assigned this Apr 4, 2025
@simonhong
Fixed crash when send tabs to desktop
8b006da 
fix brave/brave-browser#45198

Enabled related upstream test cases.
@simonhong simonhong force-pushed the fix_crash_when_send_to_desktop branch from e09b91c to 8b006da Compare April 4, 2025 03:17
@simonhong simonhong requested a review from mkarolin April 4, 2025 03:17
@simonhong simonhong marked this pull request as ready for review April 4, 2025 05:02
@simonhong simonhong requested a review from a team as a code owner April 4, 2025 05:02
cdesouza-chromium
cdesouza-chromium approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit 794fda8 into master Apr 4, 2025
18 checks passed
@simonhong simonhong deleted the fix_crash_when_send_to_desktop branch April 4, 2025 05:16
@github-actions github-actions bot added this to the 1.79.x - Nightly milestone Apr 4, 2025
brave-builds added a commit that referenced this pull request Apr 4, 2025
@brave-builds
Uplift of #28498 (squashed) to beta
f7f7701
brave-builds added a commit that referenced this pull request Apr 4, 2025
@brave-builds
Uplift of #28498 (squashed) to release
f3d8623
This was referenced Apr 4, 2025
Merged
Merged
@brave-builds
Copy link
Collaborator

Released in v1.79.31

@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2025

Verification PASSED on Win 11 x64 & Pixel 6 running Android 15 using the following build(s):

Brave | 1.79.31 Chromium: 135.0.7049.52 (Official Build) nightly (64-bit)
-- | --
Revision | 0d804efdcd10dd258b1973c0588fce81c870568c
OS | Windows 11 Version 24H2 (Build 26100.3476)

Test Case #1 - Sharing from Desktop -> Android

Prerequisite: ensure that you have Sync enabled on both devices before sharing tabs/links

  • once sync has been setup/configured on both devices, visit a random article/website on Android
  • share the page by clicking on the Share button and selecting Send to devices
  • ensure that there's a modal appearing at the bottom with a list of all the available devices
  • select a device and ensure that Brave doesn't crash/runs into any obvious issues
  • ensure that the tab appears on Desktop after a few seconds and can be opened without any issues/failures
Example Example Example Example Example Example Example Example
1000000328 1000000329 fixedShare1 fixedShare2 1000000330 1000000331 fixedShare3 fixedShare4

@MadhaviSeelam MadhaviSeelam mentioned this pull request Apr 8, 2025
Closed
6 tasks
@AlexeyBarabash AlexeyBarabash mentioned this pull request May 1, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdesouza-chromium cdesouza-chromium cdesouza-chromium approved these changes

@mkarolin mkarolin Awaiting requested review from mkarolin

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.79.x - Beta
Development

Successfully merging this pull request may close these issues.

crashes when sending tabs from mobile to desktop
4 participants
@simonhong @brave-builds @kjozwiak @cdesouza-chromium