-
Notifications
You must be signed in to change notification settings - Fork 965
Fixed vpn crash when using newly supported timezone #27791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix brave/brave-browser#44181 When new region is added to timezone list and it's same with user's timezone, vpn service tries to map it to v2's name via GetMigratedNameIfNeeded(). However, new region is not included in kV1ToV2Map, it causes crash. When it's not in that map, use that name instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good fix as-is - but I think we could (in a follow up) switch to using ISO codes instead (for this mapping). But since this is a bad issue affecting some customers, I don't want to block 👍
Released in v1.77.66 |
Verification PASSED on
Using the STR/Cases outlined via #27791 (comment), I managed to reproduce the issue using
Using the same STR/Cases mentioned above, |
fix brave/brave-browser#44181
When new region is added to timezone list and it's same with user's timezone, vpn service tries to map it to v2's name via GetMigratedNameIfNeeded(). However, new region is not included in kV1ToV2Map, it causes crash. When it's not in that map, use that name instead.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Asia/Jerusalem
to machine's timezone