Skip to content

Fixed vpn crash when using newly supported timezone #27791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 25, 2025

fix brave/brave-browser#44181

When new region is added to timezone list and it's same with user's timezone, vpn service tries to map it to v2's name via GetMigratedNameIfNeeded(). However, new region is not included in kV1ToV2Map, it causes crash. When it's not in that map, use that name instead.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Set Asia/Jerusalem to machine's timezone
  2. Launch brave with clean profile
  3. Set VPN as purchased state
  4. No crash

fix brave/brave-browser#44181

When new region is added to timezone list and it's same with user's
timezone, vpn service tries to map it to v2's name via GetMigratedNameIfNeeded().
However, new region is not included in kV1ToV2Map, it causes crash.
When it's not in that map, use that name instead.
@simonhong simonhong self-assigned this Feb 25, 2025
@simonhong simonhong changed the title Fixed crash when using new region Fixed vpn crash when using newly supported timezone Feb 25, 2025
@simonhong simonhong marked this pull request as ready for review February 25, 2025 05:08
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix as-is - but I think we could (in a follow up) switch to using ISO codes instead (for this mapping). But since this is a bad issue affecting some customers, I don't want to block 👍

@bsclifton bsclifton merged commit adaada1 into master Feb 25, 2025
19 checks passed
@bsclifton bsclifton deleted the fix_vpn_crash branch February 25, 2025 19:38
@bsclifton bsclifton added this to the 1.77.x - Nightly milestone Feb 25, 2025
brave-builds added a commit that referenced this pull request Feb 25, 2025
brave-builds added a commit that referenced this pull request Feb 25, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.66

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

<!--StartFragment-->
Brave | 1.77.66 Chromium: 134.0.6998.24 (Official Build) nightly (64-bit)
-- | --
Revision | 3c85819d4e64a4ec3e0faf11b5878ab57e0f66e6

Using the STR/Cases outlined via #27791 (comment), I managed to reproduce the issue using 1.77.64 Chromium 134.0.6998.24 via the following:

Prerequisite: Ensure that Jerusalem is selected as the machines timezone before launching new profile.

  • launched 1.77.64 Chromium 134.0.6998.24 and started the process of getting a new trail on a new email
  • created the account, added my CC information (used internal promo so CC doesn't get charged)
  • once the CC information was apprroved and the credentials were loaded, Brave crashed instantly:
* 319d1c00-b339-6c0d-0000-000000000000
* 2f9d1c00-b339-6c0d-0000-000000000000

image

Using the same STR/Cases mentioned above, 1.77.66 Chromium: 134.0.6998.24 was installed and the same profile was launched without experiencing any crashes. Connected to the Israel VPN endpoint without issues as per the following:

connected1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when using Brave VPN for specific timezone(s)
4 participants