Skip to content

Fixes Norwegian localization for shields and rewards. #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jun 15, 2019

Fixes brave/brave-browser#3425

  • Renames Norwegian resources locale from 'nb' back to 'no', so that
    Transifex produces translations for them. When copying these resources
    rename them to 'nb'.

Submitter Checklist:

Test Plan:

  1. Change your OS locale (or Brave UI language where available) to Norwegian
  2. In Brave, click on Rewards extension icon and check that the popup is localized.
  3. Navigate to any site, click on Shields extension icon and check that the popup is localized.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes brave/brave-browser#3425

- Renames Norwegian resources locale from 'nb' back to 'no', so that
  Transifex produces translations for them. When copying these resources
  rename them to 'nb'.
@mkarolin mkarolin added this to the 0.68.x - Nightly milestone Jun 15, 2019
@mkarolin mkarolin self-assigned this Jun 15, 2019
@mkarolin mkarolin changed the title WIP: Fixes Norwegian localization for shields and rewards. Fixes Norwegian localization for shields and rewards. Jun 15, 2019
@mkarolin mkarolin merged commit d0ee484 into master Jun 16, 2019
@mkarolin mkarolin deleted the maxk-fix-norwegian-l10n branch June 16, 2019 16:18
@kjozwiak
Copy link
Member

I reproduced the original issue using 0.68.54 Chromium: 75.0.3770.90 and confirmed/verified using 0.68.57 Chromium: 75.0.3770.90. Definitely looks like it's been resolved! Examples using 0.68.57 Chromium: 75.0.3770.90:

Screen Shot 2019-06-18 at 1 19 06 AM

Screen Shot 2019-06-18 at 1 18 58 AM

Screen Shot 2019-06-18 at 1 17 25 AM

Screen Shot 2019-06-18 at 1 15 34 AM

mkarolin added a commit that referenced this pull request Jun 18, 2019
Fixes Norwegian localization for shields and rewards.
mkarolin added a commit that referenced this pull request Jun 18, 2019
Fixes Norwegian localization for shields and rewards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shields Panel and Rewards Panel are not translated to Norwegian
3 participants