Skip to content

Moves contribution into separate files #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Moves contribution into separate files #2654

merged 2 commits into from
Jun 12, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 11, 2019

Resolves brave/brave-browser#4807

Submitter Checklist:

Test Plan:

  • make sure that contribution still works
  • it's also covered with tests

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc force-pushed the contribution-split branch 3 times, most recently from cd22c4c to 4fa07fa Compare June 11, 2019 14:25
@NejcZdovc NejcZdovc self-assigned this Jun 11, 2019
@NejcZdovc NejcZdovc force-pushed the contribution-split branch from 4fa07fa to dafc0d8 Compare June 11, 2019 15:26
@NejcZdovc NejcZdovc marked this pull request as ready for review June 11, 2019 15:26
@NejcZdovc NejcZdovc force-pushed the contribution-split branch from dafc0d8 to f8ff734 Compare June 11, 2019 15:34
@NejcZdovc NejcZdovc requested a review from tmancey June 11, 2019 15:34
@NejcZdovc NejcZdovc force-pushed the contribution-split branch from f8ff734 to db7a010 Compare June 11, 2019 15:36
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 11, 2019
@NejcZdovc NejcZdovc force-pushed the contribution-split branch from db7a010 to 99ce304 Compare June 12, 2019 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split big bat_contribution file in ledger
2 participants