-
Notifications
You must be signed in to change notification settings - Fork 965
[PWA]: Add 'Show apps' menu entry #26348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
f0bf21f
to
ef33e27
Compare
@@ -92,4 +92,8 @@ void ShowWalletSettings(Browser* browser) { | |||
ShowSingletonTabOverwritingNTP(browser, GURL(kWalletSettingsURL)); | |||
} | |||
|
|||
void ShowAppsPage(Browser* browser) { | |||
ShowSingletonTabOverwritingNTP(browser, GURL(chrome::kChromeUIAppsURL)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well from private(tor) window? Maybe it should be opened in normal window even it's requested from private window's app menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ and it would be great to update test for this new adding in BraveAppMenuModelBrowserTest::CheckMoreToolsCommandsAreInOrderInMenuModel()
Released in v1.73.75 |
Resolves brave/brave-browser#16898
cc @aguscruiz @rebron
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Show apps
entrychrome://apps
page